Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poam-link constraints #1052

Draft
wants to merge 24 commits into
base: canary
Choose a base branch
from
Draft

poam-link constraints #1052

wants to merge 24 commits into from

Conversation

wandmagic
Copy link

@wandmagic wandmagic commented Dec 30, 2024 •
edited
Loading

Committer Notes

adding constraints for poam item linkage

  • ssp-component-has-poam-link
  • ssp-poam-item-exists
  • ssp-poam-link-has-resource-fragment
  • ssp-poam-link-references-valid-resource
  • ssp-poam-resource-has-oscal-link
  • has-poam-resource

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner December 30, 2024 17:11
@wandmagic wandmagic marked this pull request as draft December 30, 2024 17:12
@wandmagic wandmagic force-pushed the feature/poam-link-2 branch 2 times, most recently from c676d04 to 2030e2e Compare December 30, 2024 17:45
@wandmagic wandmagic marked this pull request as ready for review December 30, 2024 17:46
@wandmagic
Copy link
Author

new version of #1024

Gabeblis
Gabeblis previously requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor message changes.

src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
@wandmagic wandmagic requested a review from Gabeblis December 30, 2024 18:07
@wandmagic wandmagic force-pushed the feature/poam-link-2 branch 2 times, most recently from c2932e2 to add4594 Compare December 30, 2024 19:21
@aj-stein-gsa aj-stein-gsa linked an issue Dec 30, 2024 that may be closed by this pull request
Each Interconnection, Service, or Software Connecting to an External Systems Must be Linked to a POA&M Entry #934
Open
14 tasks
aj-stein-gsa
aj-stein-gsa requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback on wording.

More generally, and maybe this warrants a discussion, do we need need to be careful with //back-matter/resources across all model instances, and not focusing on SSP? Later on, this could cause over-generalized matches if we incidentally add such POAM linkage over time in other documents in a package (I know we don't do that now, but we should be precise here IMO). I would love feedback from the rest of the team during review and re-review.

features/steps/fedramp_extensions_steps.ts Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-allowed-values.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved
@wandmagic
Copy link
Author

That's a good point I'll adjust the targeting

@wandmagic wandmagic force-pushed the feature/poam-link-2 branch 3 times, most recently from 88cac45 to 6cdd4d5 Compare December 30, 2024 23:39
@wandmagic
Copy link
Author

@brian-ruf please take a look at this solution, we add a fedramp-poam type to the accepted values enumuration under fedramp namespaces this allows us to differentiate between the fedramp poam resource, and other poam resources which may exist.

@aj-stein-gsa please take a look at the media-type information inside the valid poam resource, oscal-mode=poam let me know if this is the correct usage of the mime-type parameters you suggested. I filter this by media-type contains('oscal') to determine if the rlink is oscal or not.

@wandmagic wandmagic requested a review from brian-ruf January 2, 2025 17:46
@wandmagic wandmagic mentioned this pull request Jan 2, 2025
Draft
@wandmagic wandmagic marked this pull request as draft January 3, 2025 16:17
@wandmagic
Copy link
Author

Converting to draft until requirements are full defined

@wandmagic wandmagic changed the base branch from develop to canary January 10, 2025 20:07
wandmagic and others added 9 commits January 10, 2025 15:25
@wandmagic
~
84914e6
@wandmagic
Squashed commit of the following:
cdf2fa6 
commit 7c6b0f2
Merge: f10ace6 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Fri Jan 10 11:49:42 2025 -0500

    Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary

commit f10ace6
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit d7af65c
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit ee65d47
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit b9ca17a
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit f556138
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit 60ba7f7
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 11:15:47 2025 -0500

    add inventory item constraints (GSA#1063)

    * add inventory item constraints

    * update example file

    Co-Authored-By: A.J. Stein <[email protected]>

    * improve scan type constraint

    * massage constraints

    * improve constraint content

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update fedramp-external-constraints.xml

    * Update fedramp-external-constraints.xml

    * Squashed commit of the following:

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 8c1a343
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 11:45:37 2025 -0500

        Add new metapath target to 'security-level' constraint (GSA#1079)

    commit 608080d
    Author: wandmagic <[email protected]>
    Date:   Thu Jan 9 09:29:17 2025 -0500

        add additional sample content (GSA#1081)

    commit 1f55a73
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 09:22:28 2025 -0500

        Correct constraint message. (GSA#1085)

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    ---------

    Co-authored-by: A.J. Stein <[email protected]>
    Co-authored-by: Gabeblis <[email protected]>

commit 5e3f386
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 09:25:07 2025 -0500

    make build (GSA#1080)

commit 8c1a343
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 11:45:37 2025 -0500

    Add new metapath target to 'security-level' constraint (GSA#1079)

commit 608080d
Author: wandmagic <[email protected]>
Date:   Thu Jan 9 09:29:17 2025 -0500

    add additional sample content (GSA#1081)

commit 1f55a73
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 09:22:28 2025 -0500

    Correct constraint message. (GSA#1085)

commit 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (GSA#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (GSA#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit dd20034
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit b4d3df5
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (GSA#1070)

commit 719cf2c
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit ec7affc
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

commit d8a9ec9
Author: DimitriZhurkin <[email protected]>
Date:   Fri Jan 3 11:20:23 2025 -0700

    Add connection-security constraint (issue GSA#961) (GSA#1021)

    * Add connection-security constraint (issue GSA#961)

    * change fedramp ns to http

    * Add help-url

commit 1648871
Author: Kylie Hunter <[email protected]>
Date:   Fri Jan 3 13:02:59 2025 -0500

    Image has checksum (GSA#1053)

    * test scaffolds added

    * initial attempt at writing pass and fail content

    * feature file

    * revised target to appropriate place

    * removed old target

    * added in proper ns

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: A.J. Stein <[email protected]>

    * AJ suggestion for more complete example

    * added comments

    ---------

    Co-authored-by: A.J. Stein <[email protected]>

commit 962a9c0
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:31:04 2025 -0500

    Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056)

commit 836b224
Author: Rene Tshiteya <[email protected]>
Date:   Fri Jan 3 12:25:35 2025 -0500

    Fix implemented-component component-uuid references (GSA#1059)

    Fix component issues

commit 7018c20
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:24:47 2025 -0500

    Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)
@wandmagic
update pr to target canary
a792fe3
@wandmagic
remove duplicates
cd473dc
@wandmagic
Squashed commit of the following:
042a250 
commit 719cf2c
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit ec7affc
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

commit d8a9ec9
Author: DimitriZhurkin <[email protected]>
Date:   Fri Jan 3 11:20:23 2025 -0700

    Add connection-security constraint (issue GSA#961) (GSA#1021)

    * Add connection-security constraint (issue GSA#961)

    * change fedramp ns to http

    * Add help-url

commit 1648871
Author: Kylie Hunter <[email protected]>
Date:   Fri Jan 3 13:02:59 2025 -0500

    Image has checksum (GSA#1053)

    * test scaffolds added

    * initial attempt at writing pass and fail content

    * feature file

    * revised target to appropriate place

    * removed old target

    * added in proper ns

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: A.J. Stein <[email protected]>

    * AJ suggestion for more complete example

    * added comments

    ---------

    Co-authored-by: A.J. Stein <[email protected]>

commit 962a9c0
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:31:04 2025 -0500

    Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056)

commit 836b224
Author: Rene Tshiteya <[email protected]>
Date:   Fri Jan 3 12:25:35 2025 -0500

    Fix implemented-component component-uuid references (GSA#1059)

    Fix component issues

commit 7018c20
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:24:47 2025 -0500

    Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)
@wandmagic @aj-stein-gsa @Gabeblis
update from canary
78330f4 
Co-Authored-By: A.J. Stein <[email protected]>
Co-Authored-By: Gabeblis <[email protected]>
@wandmagic
get canary
0a4ca0a
@wandmagic
~
9f46f60
@wandmagic
use versions in matrix for snapshot testing
5679abd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabeblis Gabeblis Awaiting requested review from Gabeblis

@Rene2mt Rene2mt Awaiting requested review from Rene2mt

@kyhu65867 kyhu65867 Awaiting requested review from kyhu65867

@aj-stein-gsa aj-stein-gsa Awaiting requested review from aj-stein-gsa

@brian-ruf brian-ruf Awaiting requested review from brian-ruf

At least 2 approving reviews are required to merge this pull request.

Assignees

@wandmagic wandmagic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Each Interconnection, Service, or Software Connecting to an External Systems Must be Linked to a POA&M Entry
3 participants
@wandmagic @Gabeblis @aj-stein-gsa