Add the inter-boundary-component-has-class-attribute constraint #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
requested changes
Jan 10, 2025
...raints/content/ssp-inter-boundary-component-information-type-has-class-attribute-INVALID.xml
Outdated
Show resolved
Hide resolved
...raints/content/ssp-inter-boundary-component-information-type-has-class-attribute-INVALID.xml
Outdated
Show resolved
Hide resolved
DimitriZhurkin
force-pushed
the
add-inter-boundary-component-information-type-has-class-attribute
branch
from
c3699d8 to
83d0b3c
Compare
DimitriZhurkin
force-pushed
the
add-inter-boundary-component-information-type-has-class-attribute
branch
from
3498780 to
9b8ba8c
Compare
Gabeblis
reviewed
Jan 15, 2025
| <expect id="inter-boundary-component-information-type-has-class-attribute" target="$inter-boundary-component" test="prop[@name='information-type' and @ns='http://fedramp.gov/ns/oscal']/@class => exists()" level="ERROR"> | ||
| <formal-name>Inter-Boundary Component's Information Type Has @class Attribute</formal-name> | ||
| <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#external-systems-and-services-not-having-fedramp-authorization"/> | ||
| <message>In a FedRAMP SSP, the information-type property of the inter-boundary communication component MUST have the @class attribute. The @class attribute MUST NOT be empty, and it MUST contain a valid value (incoming or outgoing).</message> |
There was a problem hiding this comment.
Per my original feedback, I think this message still doesn't align with fr113 and should be slightly reworded. I also wouldn't add the allowed values in the message. We have the information-type allowed values constraint and documentation for that. It would also require more maintenance if the allowed values ever changed.
Suggested change
| <message>In a FedRAMP SSP, the information-type property of the inter-boundary communication component MUST have the @class attribute. The @class attribute MUST NOT be empty, and it MUST contain a valid value (incoming or outgoing).</message> | |
| <message>In a FedRAMP SSP, the information type of an inter-boundary communication component MUST include the network traffic direction.</message> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This constraint tests the following scenario:
In inter-boundary communication components, the
information-typeproperties have the@classattributes.Related issue #930.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.