Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register planet biomes on preinit #84

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Feb 24, 2024

Fixes GTNewHorizons/GT-New-Horizons-Modpack#12500 (comment)

Issue in Witchery's biome changing potion is due to GC's dynamic registered biomes. The server will always have them registered, but the clients wont until they go to the planet.

@Caedis Caedis requested a review from a team February 24, 2024 17:47
@Caedis
Copy link
Member Author

Caedis commented Feb 24, 2024

Tested locally on a test server with Witchery + many additional biomes + GC

Before fix: Same as the issue that will be closed
After fix: First biome and the last biome in the biome book worked as expected

@glowredman
Copy link
Member

Did you also test with GS?

@Caedis
Copy link
Member Author

Caedis commented Feb 24, 2024

Just checked the code and we will have to do the same there

@Caedis
Copy link
Member Author

Caedis commented Feb 24, 2024

lmk if you can think of a better way to do this. This was just my initial idea for a working fix

@glowredman
Copy link
Member

I don't know a cleaner way, though I'd suggest adding a comment explaining why you're doing it. Otherwise someone may simply remove this in the future because the method doesn't do anything besides initializing the classes (which may not be obvious).

@Caedis Caedis requested a review from glowredman February 25, 2024 02:43
@Dream-Master Dream-Master merged commit ae3be50 into master Feb 25, 2024
1 check passed
@Dream-Master Dream-Master deleted the fix/registerBiomes branch February 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book of biomes from witchery has biome pages shifted by 1
3 participants