Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to disable dolly stacking #32

Merged
merged 4 commits into from
May 27, 2024

Conversation

brandyyn
Copy link
Contributor

It is disabled as default, dollies are way too powerful to carry so many dollies out on your adventures in my pack

@chochem
Copy link
Member

chochem commented May 21, 2024

I dont know about that default.
At the least you will need to turn it on in the GTNH config repo as we want the feature here.

@chochem
Copy link
Member

chochem commented May 21, 2024

ah wait. judging by the code you mean that the disabling is disabled by default? XD

@ah-OOG-ah
Copy link
Member

The config is disabled by default, and the feature is disabling folded dollies. So confusing double negative, but it doesn't change current behavior.

@brandyyn
Copy link
Contributor Author

I dont know about that default. At the least you will need to turn it on in the GTNH config repo as we want the feature here.

the config option is disabled by default; sorry i didn't think of the double negative. enabling the config will turn off the ability to collapse dollies

Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature.
Just improve configuration naming to prevent even more confusion.

src/main/java/mcp/mobius/betterbarrels/BetterBarrels.java Outdated Show resolved Hide resolved
src/main/java/mcp/mobius/betterbarrels/BetterBarrels.java Outdated Show resolved Hide resolved
@brandyyn
Copy link
Contributor Author

better?

@Dream-Master Dream-Master requested review from OneEyeMaker and a team May 27, 2024 12:26
@Dream-Master Dream-Master merged commit b6f6a3b into GTNewHorizons:master May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants