Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Presets Scroll; Fix Placeholder position in the quantity field; Hide rendering error in chat; #555

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

slprime
Copy link
Member

@slprime slprime commented Nov 16, 2024

  1. Cleaned up the code
  2. Presets: change page in left panel by scrolling
  3. Item Quantity: show placeholder from the beginning
  4. Search items: show more information about the errors (Log spamming when opening a AE terminal & can't pattern certain recipes from NEI GT-New-Horizons-Modpack#17608)
  5. Don't show rendering error in chat (only in console)

@slprime slprime requested a review from a team November 16, 2024 09:13
@wlhlm
Copy link
Member

wlhlm commented Nov 17, 2024

Please spend the effort of explaining the changes in the PR description or commit message next time. Doesn't have to be a novel.

@slprime slprime requested a review from Alexdoru November 17, 2024 09:52
Copy link
Member

@Alexdoru Alexdoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you edit your PR title + description and detail the changes that you are making since it's actually more than "code cleanup"

@slprime slprime changed the title Small Changes Fix Presets Scroll; Fix Placeholder position in the quantity field; Hide rendering error in chat; Nov 17, 2024
@slprime slprime requested a review from Alexdoru November 17, 2024 11:12
@Dream-Master Dream-Master merged commit a0e1683 into GTNewHorizons:master Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants