Wirelesshub #24
Open
Wirelesshub #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chochem
added
the
ongoing freeze - do not merge
Glease
reviewed
Dec 5, 2024
There was a problem hiding this comment.
- drop with color configured thing: you are now using item meta 17 for the hub. just like the non-hub code that already exists here, you can use meta 17~34 for the hub (with 17 as colorless). e..g use
stack.setItemDamage(te.color ==AEColor.Transparent ? 17 : 17 + te.color.ordinal() + 1)in getDrops() and then set the color like the existing code inonBlockPlacedBy() - I'd very much prefer to have different texture for hubs. I've sent a request in #texture-dev, but if they are too occupied with other matter, using same texture is also acceptable for now
|
some work from our artists
|
Dream-Master
removed
the
ongoing freeze - do not merge
|
I like H variant. |
|
Ready, new texture will be later. God bless soul anyone who will brave enough to do code review.. |
serenibyss
reviewed
Dec 27, 2024
src/main/scala/net/bdew/ae2stuff/machines/wireless/TileWireless.scala
Outdated
Show resolved
Hide resolved
|
I know is just QoL, but is not the recipe like very simple? |
Yea if the recipe match a bit more with other ae and addons mods I am happy @lordIcocain |
|
Alright, i removed in mod recipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hub -> Hub = NO
Wireless -> Hub = OK
Wireless <- Hub = Wireless -> Hub
Not use power, should require Neutronium cell in recipe. (i can change)Pick up only with wrench. idk how set meta when break. no color pick up.Looks same as Wireless.Closes GTNewHorizons/GT-New-Horizons-Modpack#14729
upd.
Added custom texture and color pickup.
Added power usage, sum power usage of connected wireless.
Added recipe.
Added qols in adv tools for working with hub.
Added ability to clear adv tool queue.