Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: error handling and batch output to table #51

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: error handling and batch output to table #51

wants to merge 6 commits into from

Conversation

enigbe
Copy link
Contributor

@enigbe enigbe commented Nov 25, 2022 •
edited
Loading

What this PR does

  • adds a GaloyCliError client error to handle and propagate different errors
  • show batch payments in table

Related issue(s)

@enigbe enigbe self-assigned this Nov 25, 2022
@enigbe enigbe force-pushed the refactor-improve-error-handling branch from dea9857 to 45f4657 Compare November 29, 2022 08:17
@enigbe enigbe marked this pull request as ready for review November 29, 2022 08:27
@enigbe enigbe changed the title refactor: improve error handling across the client refactor: error handling and batch output to table Nov 29, 2022
@sandipndev sandipndev force-pushed the main branch 4 times, most recently from 64ab5f2 to 330afe0 Compare August 3, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasburtey nicolasburtey Awaiting requested review from nicolasburtey

@sandipndev sandipndev Awaiting requested review from sandipndev

@bodymindarts bodymindarts Awaiting requested review from bodymindarts

At least 1 approving review is required to merge this pull request.

Assignees

@enigbe enigbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enigbe