feat: add unit test rule to core/api buck file #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
buckify-checks
branch
from
c4b12a6 to
4c70f1e
Compare
vindard
commented
Oct 17, 2023
vindard
force-pushed
the
buckify-checks
branch
from
4c70f1e to
4d899af
Compare
| else: | ||
| return arg | ||
| cmd = f'jq -n env' |
There was a problem hiding this comment.
I would prefer if we could do this in python only...
vindard
force-pushed
the
buckify-checks
branch
from
4d899af to
834312c
Compare
vindard
force-pushed
the
buckify-checks
branch
from
834312c to
d22327d
Compare
vindard
force-pushed
the
buckify-checks
branch
from
d22327d to
6eac574
Compare
bodymindarts
approved these changes
Nov 18, 2023
| name = "unit-tests", | ||
| srcs = [":src"] + [":test_src"] + glob([".env", "galoy.yaml"]), | ||
| config_file = "test/unit/jest.config.js", | ||
| env_file = ".env", |
There was a problem hiding this comment.
I would prefer to bring this into the file instead of relying on the on disk state like in the Tiltfile.
Ideally we would be able to delete all the .env files and rely on environment defined in code. I don't know if that's feasible yet - we can merge as is to not mess with the existing workflow - but I think that should be the goal once legacy workflows are entirely deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests to buck with the caveat that unit tests currently have a dependency on env variables and the correct ones must be brought in via a
.envfile.This requirement can probably be refactored out in future.