fix: add axios option withCredentials to acceptOAuth2LoginRequest #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
force-pushed
the
send-cookies-on-accept-login
branch
from
7b34fe7 to
3f3517f
Compare
|
it should probably have to be done in the consent/page.ts also, because this is where the redirect to hydra happens |
even though the final redirect is done as a server side component so I don't think would have much effect |
bodymindarts
force-pushed
the
send-cookies-on-accept-login
branch
from
3f3517f to
187c7d1
Compare
|
Let's see what happened with this rolled out - domain is being set correctly already. This is how we got it working in Kratos. If it doesn't work we'll have to turn off SSR for consent app I guess. EDIT: added |
nicolasburtey
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent to what we had to do in the web wallet here: https://github.com/GaloyMoney/web-wallet/blob/5bb016a1adbe556ae4d09070daa3c18fb9599ce9/src/components/pages/login-email.tsx#L75 (ie pass options down to axios to forward cross site cookies)