Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mocked provider #62

Merged
merged 9 commits into from
Mar 19, 2024
Merged

feat: add mocked provider #62

merged 9 commits into from
Mar 19, 2024

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Mar 18, 2024

Description

This is to allow the configuration of mock values for realtime price for cases like testing purposes, similar to how this was introduced in stablesats here

@vindard vindard requested a review from dolcalmi March 18, 2024 19:38
@vindard vindard force-pushed the add-mocked-provider branch from e60c8d1 to e202473 Compare March 18, 2024 19:44
Copy link
Contributor

@dolcalmi dolcalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just 1 comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you got errors? I think this file is not necessary https://github.com/GaloyMoney/price/blob/main/eslintrc.base.json#L34

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@vindard vindard merged commit 39c302f into main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants