Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

VadymBezdushnyi
Copy link

Ukranian language support

Added ukranian language support
@VadymBezdushnyi VadymBezdushnyi changed the title Master Language support Apr 28, 2017
@GassaFM
Copy link
Owner

GassaFM commented May 1, 2017

Thanks! However, I'm hesitant to merge this in the master branch, since I don't clearly see the way to maintain it up-to-date.

For example, there is a Kazakh translation also. If we want to keep all translations in one place, there are a few concerns:

  1. We have to find a way to keep them up-to-date in case strings are changed or added. One way is to create a GitHub organization and move the repository there. Another is to keep things as they are now, perhaps mentioning the translations in the readme.

  2. If the number of languages keep increasing, the .sty file may eventually grow to a mess, so some modularization would be in order.

@artikz, @VadimBezdushny:
What you think of the points above? Also, would you happen to know what are best practices for maintaining a .sty file with translations?

@artikz
Copy link

artikz commented May 1, 2017

I don't know about best practices and have no experience with .sty other than olymp.sty, but I had an idea that olymp.sty could be auto generated from some other more modular set of files with a script for given specific set of languages.

@kunyavskiy
Copy link
Collaborator

kunyavskiy commented May 1, 2017

I think keeping in one place, and adding new keywords just using russian/english translations for languages person don't know is ok. Mostly, new keywords are very specific, and can be added when they are really needed for used language.

Maybe it's good idea also ask @MikeMirzayanov what is more suitable for polygon support.

@VadymBezdushnyi
Copy link
Author

In my opinion, we should create folders/files with other languages, so adding new language will not corrupt any other. The Idea that olymp.sty will be auto-generated depending on problem language is great too. But such innovations requires many changes in the current repository. So let's wait for @MikeMirzayanov suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants