Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHEZ - kahuihut - document infrasound (InfraBSU) gain configuration across datalogger history (q330/Centaur) #2158

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

CBurton90
Copy link
Contributor

No description provided.

@CBurton90 CBurton90 requested a review from rumachan July 29, 2024 03:14
@CBurton90 CBurton90 requested review from ozym and a team as code owners July 29, 2024 03:14
Copy link
Contributor

@salichon salichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thomas-Benson
Smart "subsource" F ... for
Subsource | The sensor channel(s), as defined in the response configuration, which requires a gain adjustment, multiple subsource channels can be joined (e.g "Z")

IF EVER .. out of (IDK what .. maybe clarity?)
shall we also populate the preamps subsource too ?
..say for the the 3?'s channels ?

either ways is good

@salichon salichon self-assigned this Jan 14, 2025
@salichon
Copy link
Contributor

Hello @Thomas-Benson @rumachan
would you go through this PR and check if still valid ?
(fell in a crack instruments ... infrasounds...)
so that we can merge or dispose.! sorry
FYI @CBurton90
Cheers
jerome

@Thomas-Benson
Copy link
Contributor

@salichon I think this is still something we should go forward with. It lost traction since there was some confusion in the other ticket around if the gains were being properly applied to polynomial response stages. Mark suggested we might need to look changing the response of the BSU infrasound to use a normal (CoefficientsTypeResponseStage) instead.

@salichon
Copy link
Contributor

salichon commented Jan 21, 2025

Will be merged
FYI @rumachan :) (welcome to give a few words and/or a tick :))

@salichon salichon merged commit d6321b2 into main Jan 21, 2025
18 checks passed
@salichon salichon deleted the BSU_gain branch January 21, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants