Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dataset table #2226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add dataset table #2226

wants to merge 1 commit into from

Conversation

ozym
Copy link
Contributor

@ozym ozym commented Sep 16, 2024

This adds a simple domain and network lookup table, it also allows for a reference citation and whether it is used in tilde

@ozym ozym requested review from a team as code owners September 16, 2024 09:25
@ozym ozym requested a review from a team as a code owner September 16, 2024 09:26
Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @ozym , that's awesome!! I haven't fully reviewed the code, so would be great if someone from @GeoNet/ssd-team can also review

Comment on lines +28 to +30
Tilde bool

tilde string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: assume this is because when decoding, you want to produce the exact same input, i.e. "True" -> "True", "TRUE" -> "TRUE" etc.?

Copy link
Contributor Author

@ozym ozym Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's on the money. It's mostly used for floating point numbers, e.g. input is 1.00 which then would go to 1.0 on output and then flag there's something different when running tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame Go doesn't allow for optional parentheses for no argument functions, otherwise you could make Tilde be a function that returns bool based on the value of tilde. But since it is required, making it into a function is a little ugly, as you'd be calling d.Tilde(), and other values d.Domain. You do get to remove a mutable variable though.
Still, I'm happy with this, thanks for the context.

This adds a simple domain and network lookup table, it also allows for a reference citation and whether it is used in tilde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants