-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dataset table #2226
base: main
Are you sure you want to change the base?
feat: add dataset table #2226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks @ozym , that's awesome!! I haven't fully reviewed the code, so would be great if someone from @GeoNet/ssd-team can also review
Tilde bool | ||
|
||
tilde string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: assume this is because when decoding, you want to produce the exact same input, i.e. "True" -> "True", "TRUE" -> "TRUE" etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's on the money. It's mostly used for floating point numbers, e.g. input is 1.00 which then would go to 1.0 on output and then flag there's something different when running tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame Go doesn't allow for optional parentheses for no argument functions, otherwise you could make Tilde
be a function that returns bool based on the value of tilde
. But since it is required, making it into a function is a little ugly, as you'd be calling d.Tilde()
, and other values d.Domain
. You do get to remove a mutable variable though.
Still, I'm happy with this, thanks for the context.
This adds a simple domain and network lookup table, it also allows for a reference citation and whether it is used in tilde
This adds a simple domain and network lookup table, it also allows for a reference citation and whether it is used in tilde