-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gnss domain to tilde config #2262
base: main
Are you sure you want to change the base?
add gnss domain to tilde config #2262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice a clean, all good
// update domains | ||
t.Domains = append(t.Domains, Domain{ | ||
Name: "gnss", | ||
Description: "Global Navigation Satellite System Sensors", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wilsonjord ! After a discussion with @elidana and @rumachan I still would like to propose changes to the domain description and go with "Global Navigation Satellite System Stations"
. Sorry for the slow review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"station" is the only terminology that is not used in tilde domain descriptions (see https://tilde.geonet.org.nz/v4/dataSummary/) and in the domain model it refers to the generalised "location" where time series data are available (can be from multiple sensors
for some domains). So maybe let's just stick to Global Navigation Satellite System
as a compromise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elidana @aleks-spes could I get a final confirmation on the last question from @elidana ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i personally vote for Global Navigation Satellite System
as a compromise
No description provided.