Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gnss domain to tilde config #2262

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wilsonjord
Copy link

No description provided.

@wilsonjord wilsonjord requested review from a team as code owners October 22, 2024 23:30
@wilsonjord wilsonjord requested a review from junghao October 22, 2024 23:46
Copy link
Contributor

@ozym ozym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice a clean, all good

@wilsonjord wilsonjord self-assigned this Oct 23, 2024
@wilsonjord wilsonjord added the do not merge Not quite ready for operations label Oct 23, 2024
// update domains
t.Domains = append(t.Domains, Domain{
Name: "gnss",
Description: "Global Navigation Satellite System Sensors",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wilsonjord ! After a discussion with @elidana and @rumachan I still would like to propose changes to the domain description and go with "Global Navigation Satellite System Stations". Sorry for the slow review!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"station" is the only terminology that is not used in tilde domain descriptions (see https://tilde.geonet.org.nz/v4/dataSummary/) and in the domain model it refers to the generalised "location" where time series data are available (can be from multiple sensors for some domains). So maybe let's just stick to Global Navigation Satellite System as a compromise?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elidana @aleks-spes could I get a final confirmation on the last question from @elidana ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i personally vote for Global Navigation Satellite System as a compromise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Not quite ready for operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants