Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated channel and component consistency checks #2297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ozym
Copy link
Contributor

@ozym ozym commented Nov 18, 2024

This comes down to sorting the two files

I have done a simple sort of the files in main, and the files here which show no differences;

diff channels.csv.main channels.csv.update
diff components.csv.main  components.csv.update

@ozym ozym requested review from a team as code owners November 18, 2024 21:11
@ozym ozym requested a review from elidana November 18, 2024 21:13
@ozym ozym self-assigned this Nov 18, 2024
@ozym ozym added the maintenance Keeping things in order label Nov 18, 2024
Copy link

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the sorting a requirement of the test, or a higher requirement? For non-timeseries, it would be an unusual requirement for input data to be sorted, no?

This comes down to sorting the two files
@ozym ozym force-pushed the update-channels-and-components-consistency-checks branch from 41dc014 to 68d2395 Compare November 18, 2024 22:28
@ozym
Copy link
Contributor Author

ozym commented Nov 18, 2024

is the sorting a requirement of the test, or a higher requirement? For non-timeseries, it would be an unusual requirement for input data to be sorted, no?

This was something that was designed into the system from the beginning, although in this case it was missed. The idea is to try and keep multiple commits a little easier to merge if there's a standard sorting in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping things in order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants