Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use AWS_ENDPOINT_URL env var #180

Merged
merged 1 commit into from
Nov 10, 2024
Merged

fix: use AWS_ENDPOINT_URL env var #180

merged 1 commit into from
Nov 10, 2024

Conversation

CallumNZ
Copy link
Contributor

use AWS_ENDPOINT_URL env var for Keyspaces instead of CUSTOM_AWS_ENDPOINT_URL.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested a review from bpeng November 10, 2024 20:42
@sue-h-gns sue-h-gns merged commit 27f35bc into main Nov 10, 2024
7 checks passed
@sue-h-gns sue-h-gns deleted the deprecateCustomAWS branch November 10, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants