Don't show client projects for users just assigned to a project #573
+310
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change in how permissions work. Currently, if an operator is assigned to any project for a client, they get read access to all of the client's other projects as well. This patch changes that to only allow access to the project they've been assigned. Management and users with client invitations still have full view access.
Previously client invitations were only editable via the Django admin panel. This adds a UI to the client edit page for adding and removing client invitations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 91.97% 91.93% -0.04%
==========================================
Files 323 323
Lines 18690 18761 +71
==========================================
+ Hits 17190 17248 +58
- Misses 1500 1513 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change in how permissions work. Currently, if an
operator is assigned to any project for a client, they get read access
to all of the client's other projects as well. This patch changes that
to only allow access to the project they've been assigned.
Management and users with client invitations still have full view
access.
Also adds UI for adding/removing client invitations.
(This is a rebase of #500 targeting the main branch)