Properly handle event source errors

GitbookIO · Jan 17, 2025 · a71f1c1 · a71f1c1
1 parent e3b2857
commit a71f1c1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/packages/api/package.json b/packages/api/package.json
@@ -13,7 +13,7 @@
     ],
     "dependencies": {
         "event-iterator": "^2.0.0",
-        "eventsource-parser": "^1.1.1"
+        "eventsource-parser": "^3.0.0"
     },
     "devDependencies": {
         "swagger-typescript-api": "^13.0.3",

diff --git a/packages/api/templates/http-client.ejs b/packages/api/templates/http-client.ejs
@@ -2,7 +2,7 @@
 const { apiConfig, generateResponses, config } = it;
 %>
 import { EventIterator } from 'event-iterator';
-import { createParser, type ParsedEvent, type ReconnectInterval } from 'eventsource-parser';
+import { createParser, type EventSourceMessage } from 'eventsource-parser';
 
 export type QueryParamsType = Record<string | number, any>;
 export type ResponseFormat = keyof Omit<Body, "body" | "bodyUsed">;
@@ -277,15 +277,23 @@ export class HttpClient<SecurityDataType = unknown> {
                         queue.stop();
                     }
 
-                    const parser = createParser((event: ParsedEvent | ReconnectInterval) => {
-                        if (event.type === 'event') {
-                            if (event.data === 'done') {
+                    const parser = createParser({
+                        onEvent: (event: EventSourceMessage) => {
+                            if (event.event === 'done') {
                                 stop();
+                            } else if (event.event === 'error') {
+                                const data = JSON.parse(event.data);
+                                reader.cancel();
+                                queue.fail(new Error(data.error.message));
                             } else {
                                 const data = JSON.parse(event.data);
                                 queue.push(data);
                             }
-                        }
+                        },
+                        onError: (error: Error) => {
+                            reader.cancel();
+                            queue.fail(error);
+                        },
                     })
 
                     const decoder = new TextDecoder();