env value for app installation url in github integration

GitbookIO · Nov 1, 2023 · d7f752d · d7f752d
1 parent b7047df
commit d7f752d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -84,6 +84,7 @@ jobs:
                   SENTRY_CLIENT_ID: ${{ secrets.SENTRY_STAGING_CLIENT_ID }}
                   SENTRY_CLIENT_SECRET: ${{ secrets.SENTRY_STAGING_CLIENT_SECRET }}
                   SENTRY_GITBOOK_INTEGRATION: ${{ secrets.SENTRY_STAGING_GITBOOK_INTEGRATION }}
+                  GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_INSTALL_URL }}
                   GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_ID }}
                   GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_ID }}
                   GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_SECRET }}
@@ -125,6 +126,7 @@ jobs:
                   JIRA_CLIENT_SECRET: ${{ secrets.JIRA_PROD_CLIENT_SECRET }}
                   LINEAR_CLIENT_ID: ${{ secrets.LINEAR_PROD_CLIENT_ID }}
                   LINEAR_CLIENT_SECRET: ${{ secrets.LINEAR_PROD_CLIENT_SECRET }}
+                  GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_APP_INSTALL_URL }}
                   GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_APP_ID }}
                   GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_CLIENT_ID }}
                   GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_CLIENT_SECRET }}

diff --git a/integrations/github/gitbook-manifest.yaml b/integrations/github/gitbook-manifest.yaml
@@ -42,6 +42,7 @@ configurations:
     space:
         componentId: configure
 secrets:
+    APP_INSTALL_URL: ${{ env.GITHUB_APP_INSTALL_URL }}
     APP_ID: ${{ env.GITHUB_APP_ID }}
     PRIVATE_KEY: ${{ env.GITHUB_PRIVATE_KEY }}
     CLIENT_ID: ${{ env.GITHUB_CLIENT_ID }}

diff --git a/integrations/github/src/components.tsx b/integrations/github/src/components.tsx
@@ -154,13 +154,12 @@ export const configBlock = createComponent<
                                 label="Select account"
                                 hint={
                                     <text>
-                                        Choose the GitHub installation, user or organization.
+                                        Choose the GitHub installation, user or organization.{' '}
                                         <link
                                             target={{
-                                                url: 'https://github.com/apps/gitbook-com/installations/new',
+                                                url: context.environment.secrets.APP_INSTALL_URL,
                                             }}
                                         >
-                                            {' '}
                                             Install the GitHub app.
                                         </link>
                                     </text>