Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the min length of state param to 10 in OIDC integration #661

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vibhanshub
Copy link
Contributor

Some IdPs enforce a min 8 character length for the state parameter. This changes the state param's min length from 6 to 10

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 91e5548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@gitbook/integration-oidc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks weird. You are talking about a char limit and changing a key.

@vibhanshub
Copy link
Contributor Author

@gregberge Yes, the state query param needs to be at least 8 chars long for some IdPs. Previously the state parameter being passed was just state-, which is 6 chars long when the location in VA is empty. Now, when the location is empty, we will pass oidcstate- as the value for the state query param

@vibhanshub vibhanshub merged commit fedb093 into main Dec 17, 2024
8 checks passed
@vibhanshub vibhanshub deleted the vib/fix-oidc-state branch December 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants