Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui changes #5

Merged
merged 3 commits into from
Aug 2, 2015
Merged

Ui changes #5

merged 3 commits into from
Aug 2, 2015

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Jul 28, 2015

No description provided.

xzfc added 3 commits July 28, 2015 06:07
@xzfc
Universal draw_text function to replace draw_text_center and draw_tex…
5921e36 
…t_left

Fixed size calculation for centering
Fixed non-integer division
Added outline option
@xzfc
Nice leaderboard hud
04b8d79
@xzfc
Nice cell names and sizes
749496b
@Gjum
Copy link
Owner

Gjum commented Jul 31, 2015

I have started to merge your changes, see the ui branch.

@xzfc
Copy link
Contributor Author

xzfc commented Aug 2, 2015

Maybe replace cairo text rendering with pango due to the reasons mentioned in 1? Tldr: cairo_show_text draws ▯ if symbol is not presented in main font face; pango uses different font in that case.

@Gjum
Copy link
Owner

Gjum commented Aug 2, 2015

As I said, this client started as a sandbox and I didn't expect it to become my most popular project.

Pango would be cool, but honestly I want to focus on other stuff. If you have time to do this. I'd really appreciate it.

@Gjum
Copy link
Owner

Gjum commented Aug 2, 2015

I will merge the ui branch as it is in a few hours. Please comment if there is anything left to talk about.

@Gjum Gjum merged commit 749496b into Gjum:master Aug 2, 2015
@Gjum
Copy link
Owner

Gjum commented Aug 2, 2015

I left the leaderboard right-aligned for now, because I like it that way. But I understand the issue and you are not the only one preferring a different look. I opened #7 for that, so I won't forget it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzfc @Gjum