Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2191): Migrate from ezsp to ember driver for Z2M #2196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Jan 9, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Do you think this change could also impact Zigbee2mqtt backups? For instance, if someone is using the old driver and moves to a new Gladys installation with the new driver, would it break the restore process?

From this part, no issue
Koenkk/zigbee2mqtt#21462 (comment)

Coordinator Backup & Restore

  • If you have an ezsp v12 backup that you've used for testing before, this should restore it the same. ✅
  • If you had been using v13 for previous ezsp tests (no backup available), and you keep your network settings in configuration.yaml the same (meaning they will match that of the adapter the last time it ran), after swapping for ember, it should simply take over where you left off (and this time you should get a backup file out of it as a bonus!).

⚠️ Do we need to check listed dongle between here and in Gladys ?

Copy link

relativeci bot commented Jan 9, 2025

#2933 Bundle Size — 10.41MiB (0%).

084e89e(current) vs e9b3211 master#2931(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2933
     Baseline
#2931
No change  Initial JS 5.64MiB 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2933
     Baseline
#2931
No change  JS 7.43MiB 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch cicoub13:fix-2191Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (e9b3211) to head (084e89e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2196   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14420    14420           
=======================================
  Hits        14209    14209           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant