Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rag solution nb #413

Merged
merged 3 commits into from
Feb 8, 2024
Merged

add rag solution nb #413

merged 3 commits into from
Feb 8, 2024

Conversation

kylesteckler
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title to be a bit more specific? Something like, "Retrieval Augmented Generation (RAG) System using LangChain and ChromaDB". I anticipate we will have another lab with vector search in the near future.

Also, update the objectives to mention, using "ChromaDB"


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note here saying that "cosine similarity" is one of the many similarity measures that can be used. But there are others.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, read this results of the similarity and sort in descending order using python here. So that it'll show the decreasing similarity between the information that you have.


Reply via ReviewNB

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unclear, what would become the "context" and what would become the "query". Maybe provide a bit more detail.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #10.        If you cannot answer the question using only the provided context, repond that you do not have the context needed to answer the question.

Typo, repond->respond


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,1034 @@
{
Copy link
Collaborator

@sanjanalreddy sanjanalreddy Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


Reply via ReviewNB

@kylesteckler kylesteckler merged commit f3497a5 into master Feb 8, 2024
3 of 4 checks passed
@kylesteckler kylesteckler deleted the rag branch February 9, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants