Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a navigational structure based on aip.dev #1253

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Adding a navigational structure based on aip.dev #1253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
980288e
Adding a navigational structure based on aip.dev
garrettjonesgoogle Feb 25, 2020
819386d
Removing search functionality
garrettjonesgoogle Feb 28, 2020
654925e
Renaming 'articles' to 'concepts'
garrettjonesgoogle Feb 29, 2020
d58e69e
Removing 'Browse best practices' link in header
garrettjonesgoogle Feb 29, 2020
146cf94
Merge branch 'master' of https://github.com/GoogleCloudPlatform/cloud…
garrettjonesgoogle Feb 29, 2020
c88386a
Removing unused stuff
garrettjonesgoogle Mar 3, 2020
cce5989
Consolidating scss to one file
garrettjonesgoogle Mar 4, 2020
29373ee
PR feedback
garrettjonesgoogle Mar 4, 2020
05797a0
Merge branch 'master' of https://github.com/GoogleCloudPlatform/cloud…
garrettjonesgoogle Mar 4, 2020
30a36af
Removing unnecessary diffs
garrettjonesgoogle Mar 4, 2020
4222e70
Removing glue.scss by applying styles using javascript
garrettjonesgoogle Mar 4, 2020
499c90a
Some more cleanup and comments
garrettjonesgoogle Mar 4, 2020
ddaed61
Removing dead code
garrettjonesgoogle Mar 4, 2020
77b5169
PR feedback
garrettjonesgoogle Mar 5, 2020
f49a7ad
PR feedback part 2
garrettjonesgoogle Mar 5, 2020
2de03ff
Moving all navigational stuff outside of main
garrettjonesgoogle Mar 5, 2020
81e3e00
Moving role attribute where it goes
garrettjonesgoogle Mar 5, 2020
157f245
Making footer black instead of grey
garrettjonesgoogle Mar 6, 2020
20deac6
Merge branch 'master' of https://github.com/GoogleCloudPlatform/cloud…
garrettjonesgoogle Mar 6, 2020
5f61c3f
Accessibility improvement
garrettjonesgoogle Mar 6, 2020
cbd9249
Removing redundant title tag
garrettjonesgoogle Mar 6, 2020
935f857
More accessibility improvements
garrettjonesgoogle Mar 7, 2020
0ae2c70
PR feedback, removing unnecessary stuff
garrettjonesgoogle Mar 9, 2020
4c2519d
Merge branch 'master' of https://github.com/GoogleCloudPlatform/cloud…
garrettjonesgoogle Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/_includes/jlbp-head-tag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
<meta charset='UTF-8'>
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,maximum-scale=2">
<link href="//fonts.googleapis.com/css?family=Roboto:100,300,400,500,700|Google+Sans:400,500|Product+Sans:400&amp;lang=en" rel="stylesheet"></link>
<link rel="stylesheet" type="text/css" media="screen" href="//www.gstatic.com/glue/v22_1/glue.min.css">
<link href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700|Google+Sans:400,500|Product+Sans:400&amp;lang=en" rel="stylesheet"></link>
<link rel="stylesheet" type="text/css" media="screen" href="https://www.gstatic.com/glue/v22_1/glue.min.css">
<link rel="stylesheet" type="text/css" media="screen" href="{{ '/assets/css/style.css?v=' | append: site.github.build_revision | relative_url }}">
{% for stylesheet in page.css -%}
<link rel="stylesheet" type="text/css" media="screen" href="{{ stylesheet | relative_url }}?v={{ site.github.build_revision }}">
{% endfor -%}
<link rel="stylesheet" type="text/css" media="print" href="{{ '/assets/css/print.css?v=' | append: site.github.build_revision | relative_url }}">
<script type="text/javascript" src="//code.jquery.com/jquery-3.4.0.min.js"></script>
<script type="text/javascript" src="//www.gstatic.com/glue/latest/glue-detect.min.js"></script>
<script type="text/javascript" src="https://code.jquery.com/jquery-3.4.0.min.js"></script>
<script type="text/javascript" src="https://www.gstatic.com/glue/latest/glue-detect.min.js"></script>
<script type="text/javascript">
$('html').css('visibility', 'hidden');
$.when($.ready).then(() => {
Expand Down
8 changes: 6 additions & 2 deletions docs/_includes/jlbp-nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@
</li>
{% endif %}{% endfor -%}
<li class="nav-item nav-item-header">Concepts</li>
<li class="nav-item{% if page.url == '/concepts-index' %} nav-item-active{% endif %}">
<a href="/concepts-index">Concepts index</a>
{% for p in site.pages %}{% if p.concepts -%}
<li class="nav-item{% if p.url == page.url %} nav-item-active{% endif %}">
<a href="{{ p.url | relative_url }}">
{{ p.title }}
</a>
</li>
{% endif %}{% endfor -%}
<li class="nav-item nav-item-header">Reference</li>
<li class="nav-item{% if page.url == '/glossary' %} nav-item-active{% endif %}">
<a href="/glossary">Glossary</a>
Expand Down
2 changes: 1 addition & 1 deletion docs/_layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
{% if page.bare %}
{{ content }}
{% else %}
{% include jlbp-nav.html %}
<main role="main" id="page-content">
{% include jlbp-nav.html %}
<section id="jump-content">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to run the site again, but it looks like there's more navigation inside main, e..g jump-content? Maybe that's the rightand sidebar? Main is for the content only. This is important for accessibility and rendering on non-desktop screens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<aside id="jlbp-sidebar" class="docs-component-sidebar">
<section id="jlbp-toc" class="docs-component-sidebar-toc">
Expand Down
4 changes: 2 additions & 2 deletions docs/_sass/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Please don't edit this file since it would create a maintenance
// burden for people trying to keep it up to date with Glue.
// This is forked from an internal file that is used to generate Glue.
// These variables don't appear in the generated Glue css, which is why
// this copy is needed.
// Please don't edit this file since it would create a maintenance
// burden for people trying to keep it up to date with Glue.
$glue-greys: (
0: #fff,
25: #f1f1f1,
Expand Down
8 changes: 0 additions & 8 deletions docs/concepts-index.md
View file
Open in desktop

This file was deleted.