Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn incompatible class files #2391

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ static ClassDumper create(List<ClassPathEntry> entries) throws IOException {
.collect(toImmutableList());
checkArgument(
unreadableFiles.isEmpty(), "Some jar files are not readable: %s", unreadableFiles);

Map<String, ClassPathEntry> map = new HashMap<>();
for (ClassPathEntry entry : entries) {
for (String className : entry.getFileNames()) {
Expand All @@ -98,7 +98,7 @@ static ClassDumper create(List<ClassPathEntry> entries) throws IOException {
}
}
}

return new ClassDumper(entries, extensionClassLoader, map);
}

Expand Down Expand Up @@ -141,37 +141,54 @@ static boolean isArrayClass(String className) {
return className.startsWith("[");
}

/**
* Returns a map from classes to the symbol references they contain.
*/
/** Returns a map from classes to the symbol references they contain. */
SymbolReferences findSymbolReferences() throws IOException {
SymbolReferences.Builder builder = new SymbolReferences.Builder();

for (ClassPathEntry jar : inputClassPath) {
int totalClassFileCount = 0;
int incompatibleClassFileCount = 0;
for (JavaClass javaClass : listClasses(jar)) {
totalClassFileCount++;
if (isCompatibleClassFileVersion(javaClass)) {
String className = javaClass.getClassName();
// In listClasses(jar), ClassPathRepository creates JavaClass through the first JAR file
// that contains the class. It may be different from "jar" for an overlapping class.
ClassFile source = new ClassFile(findClassLocation(className), className);
builder.addAll(findSymbolReferences(source, javaClass));
} else {
incompatibleClassFileCount++;
}
}
if (incompatibleClassFileCount > 0) {
logger.warning(
String.format(
"%s has %d (out of %d) incompatible class files (class file major version is outside %d <= v <= %d).",
jar,
incompatibleClassFileCount,
totalClassFileCount,
MINIMUM_CLASS_FILE_MAJOR_VERSION,
MAXIMUM_CLASS_FILE_MAJOR_VERSION));
}
}

return builder.build();
}

private static final int MINIMUM_CLASS_FILE_MAJOR_VERSION = 45;
private static final int MAXIMUM_CLASS_FILE_MAJOR_VERSION = 52;

/**
* Returns true if {@code javaClass} file format is compatible with this tool. Currently
* Java 8 and earlier are supported.
* Returns true if {@code javaClass} file format is compatible with this tool. Currently Java 8
* (class file major version 52) and earlier are supported.
*
* @see <a href="https://docs.oracle.com/javase/specs/jvms/se11/html/jvms-4.html#jvms-4.1">Java
* Virtual Machine Specification: The ClassFile Structure: minor_version, major_version</a>
*/
private static boolean isCompatibleClassFileVersion(JavaClass javaClass) {
int classFileMajorVersion = javaClass.getMajor();
return 45 <= classFileMajorVersion && classFileMajorVersion <= 52;
return MINIMUM_CLASS_FILE_MAJOR_VERSION <= classFileMajorVersion
&& classFileMajorVersion <= MAXIMUM_CLASS_FILE_MAJOR_VERSION;
}

private static SymbolReferences.Builder findSymbolReferences(
Expand All @@ -182,7 +199,7 @@ private static SymbolReferences.Builder findSymbolReferences(
Constant[] constants = constantPool.getConstantPool();
for (Constant constant : constants) {
if (constant == null) {
continue;
continue;
}

byte constantTag = constant.getTag();
Expand Down Expand Up @@ -262,8 +279,7 @@ private static ClassSymbol makeSymbol(
return new ClassSymbol(targetClassName);
}

private static MethodSymbol makeSymbol(
ConstantCP constantMethodref, ConstantPool constantPool) {
private static MethodSymbol makeSymbol(ConstantCP constantMethodref, ConstantPool constantPool) {
String className = constantMethodref.getClass(constantPool);
ConstantNameAndType constantNameAndType = constantNameAndType(constantMethodref, constantPool);
String methodName = constantNameAndType.getName(constantPool);
Expand Down Expand Up @@ -303,7 +319,7 @@ static ImmutableSet<String> listInnerClassNames(JavaClass javaClass) {
continue;
}
}

// Class names stored in constant pool have '/' as separator. We want '.' (as binary name)
String normalInnerClassName = innerClassName.replace('/', '.');
innerClassNames.add(normalInnerClassName);
Expand Down
Loading