feat: Add option to filter linkage checker problems stemming from an artifact #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
reviewed
Jan 15, 2025
Comment on lines
+171
to
+176
| if (sourceFilterList != null) { | ||
| List<String> sourceFilterStringList = sourceFilterList.stream().map(Artifact::toString).collect(Collectors.toList()); | ||
| classFiles = classFiles.stream() | ||
| .filter(x -> sourceFilterStringList.contains(x.getClassPathEntry().getArtifact().toString())) | ||
| .collect(Collectors.toSet()); | ||
| } |
There was a problem hiding this comment.
If it's not a big problem, would you try to move the logic to problemFilter ?
There was a problem hiding this comment.
But filtering here early may have a good benefit of speed (no need to check the symbol references of non-interesting class files). If that's the intention, would you add a source code comment?
There was a problem hiding this comment.
Oh I see. I wasn't aware about problemFilter. I'll take a look and see how that's being used and see which one makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT]
Source filter is an additional argument that allows users to filter problems that come from an specific artifact. Currently, linkage checker will report any linkage problem that comes from any of the dependencies that are also resolved via Maven Resolver. This can introduce a lot of additional noise into the results.
For example:
Running Linkage Checker on BigqueryStorage + Protobuf-Java can result in linkage problems from Netty and gRPC-Java which may not be relevant to our results.