-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default service_control_enable_api_key_uuid_reporting to true #910
Conversation
/retest-required |
1 similar comment
/retest-required |
@paulhong01: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elliot-xq, paulhong01, shuoyang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
service_control_enable_api_key_uuid_reporting
to true by default will make it easier to clean up in the future, comparing settingServiceControlEnableApiKeyUidReporting
flag (since this needs to update a few unit tests/integration tests)