Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default service_control_enable_api_key_uuid_reporting to true #910

Merged
merged 4 commits into from
May 28, 2024

Conversation

paulhong01
Copy link
Contributor

@paulhong01 paulhong01 commented May 24, 2024

  • Consider that eventually we will remove this flag entirely, setting service_control_enable_api_key_uuid_reporting to true by default will make it easier to clean up in the future, comparing setting ServiceControlEnableApiKeyUidReporting flag (since this needs to update a few unit tests/integration tests)
  • I manually verified the new image again.

@paulhong01
Copy link
Contributor Author

/retest-required

1 similar comment
@paulhong01
Copy link
Contributor Author

/retest-required

Copy link

@paulhong01: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-tsan 8a63776 link true /test ESPv2-presubmit-tsan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 8a63776 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
ESPv2-presubmit-asan 8a63776 link true /test ESPv2-presubmit-asan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shuoyang2016 shuoyang2016 merged commit 538671e into master May 28, 2024
19 of 22 checks passed
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elliot-xq, paulhong01, shuoyang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulhong01 paulhong01 deleted the paulhung-dev branch June 7, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants