-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging as of Ubuntu devel packaging #349
base: main
Are you sure you want to change the base?
Update packaging as of Ubuntu devel packaging #349
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @utkarsh2102. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c32f83d
to
9168261
Compare
Thanks for your PR, I'll get back to this after we have cut a new release for Ubuntu 24.04. |
hi @utkarsh2102 I saw that as part of your PR you are vendoring all the dependencies, could we consider other options? It goes against our current norms/practices. |
hi @dorileo,
the only two options I can think of are:
the latter is too much work to maintain given the fast-moving nature of the go ecosystem and backporting them all is a tedious and time-consuming task. And hence we go with vendoring. do you have any other possible options in mind? |
Hi @utkarsh2102 I saw that for guest-configs you created a ubuntu specific packaging. Are you planning to do the same here? |
9168261
to
9872e45
Compare
9872e45
to
0f290d3
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dorileo, utkarsh2102 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/ok-to-test |
/retest |
@utkarsh2102: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hello,
This PR is an initiative to align the Debian packaging of google-guest-agent in Ubuntu and upstream (here).
The diff represents the changes we have in Ubuntu. I'm forwarding them here as they're all relevant and follow the standard Debian packaging practices. These changes are what we have in Ubuntu devel (current development branch).
These changes change how packaging is done and don't affect the resulting binaries (that is, there is no functional change). Also, it's worth noting that since the Go dependencies have been vendored, it should be sort of ignored while reviewing the PR. Other than that, the changes are small.
Please let me know if you have any questions or concerns.