Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging as of Ubuntu devel packaging #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

utkarsh2102
Copy link

@utkarsh2102 utkarsh2102 commented Feb 5, 2024

Hello,

This PR is an initiative to align the Debian packaging of google-guest-agent in Ubuntu and upstream (here).

The diff represents the changes we have in Ubuntu. I'm forwarding them here as they're all relevant and follow the standard Debian packaging practices. These changes are what we have in Ubuntu devel (current development branch).

These changes change how packaging is done and don't affect the resulting binaries (that is, there is no functional change). Also, it's worth noting that since the Go dependencies have been vendored, it should be sort of ignored while reviewing the PR. Other than that, the changes are small.

Please let me know if you have any questions or concerns.

Copy link

google-cla bot commented Feb 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow bot requested review from bkatyl and zmarano February 5, 2024 12:50
Copy link

Hi @utkarsh2102. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@utkarsh2102 utkarsh2102 force-pushed the update-debian-packaging branch 2 times, most recently from c32f83d to 9168261 Compare February 5, 2024 13:33
@dorileo
Copy link
Member

dorileo commented Feb 13, 2024

@utkarsh2102

Thanks for your PR, I'll get back to this after we have cut a new release for Ubuntu 24.04.

@zmarano zmarano requested review from dorileo and a-crate and removed request for bkatyl May 23, 2024 16:13
@dorileo
Copy link
Member

dorileo commented Aug 8, 2024

hi @utkarsh2102 I saw that as part of your PR you are vendoring all the dependencies, could we consider other options? It goes against our current norms/practices.

@utkarsh2102
Copy link
Author

hi @dorileo,

hi @utkarsh2102 I saw that as part of your PR you are vendoring all the dependencies, could we consider other options? It goes against our current norms/practices.

the only two options I can think of are:

  • vendor all the dependencies.
  • package all the dependencies separately and use the package version via d/control.

the latter is too much work to maintain given the fast-moving nature of the go ecosystem and backporting them all is a tedious and time-consuming task. And hence we go with vendoring.

do you have any other possible options in mind?

@dorileo
Copy link
Member

dorileo commented Sep 12, 2024

Hi @utkarsh2102 I saw that for guest-configs you created a ubuntu specific packaging. Are you planning to do the same here?

@utkarsh2102 utkarsh2102 force-pushed the update-debian-packaging branch from 9168261 to 9872e45 Compare September 24, 2024 07:48
@utkarsh2102 utkarsh2102 force-pushed the update-debian-packaging branch from 9872e45 to 0f290d3 Compare September 24, 2024 07:49
@utkarsh2102
Copy link
Author

@dorileo @a-crate, hey, this is ready for your review! :)

@dorileo
Copy link
Member

dorileo commented Sep 25, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo, utkarsh2102

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dorileo
Copy link
Member

dorileo commented Sep 25, 2024

/lgtm

@a-crate
Copy link
Contributor

a-crate commented Sep 25, 2024

/ok-to-test
/lgtm

@utkarsh2102
Copy link
Author

/retest

Copy link

@utkarsh2102: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
prow/presubmit/gocheck 0f290d3 link true /gocheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants