fix: Make key handle sweepable

[romanini-ciandt]

Make key handle and resource project name sweepable too.

Go template version of #11693 PR

Release Note Template for Downstream PRs (will be copied)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[romanini-ciandt]

Just realized I need to make a couple more tests on that. I'll re-open soon, sorry!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 40
Passed tests: 34
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

• kms

🟢 All tests passed!

View the build log

[romanini-ciandt]

FYI this PR should fix an opened provider issue: hashicorp/terraform-provider-google#18934

[zli82016]

I run the tests. TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample passed.

But TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample still fails with the error message

=== RUN   TestAccKMSKeyHandle_kmsKeyHandleBasicExample
=== PAUSE TestAccKMSKeyHandle_kmsKeyHandleBasicExample
=== CONT  TestAccKMSKeyHandle_kmsKeyHandleBasicExample
    resource_kms_key_handle_generated_test.go:39: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_kms_autokey_config.autokey_config will be updated in-place
          ~ resource "google_kms_autokey_config" "autokey_config" {
                id          = "folders/296033849616/autokeyConfig"
              + key_project = "projects/tf-test-key-proj0l4x6pzrzw"
                # (1 unchanged attribute hidden)
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccKMSKeyHandle_kmsKeyHandleBasicExample (162.33s)

Edit: TestAccKMSKeyHandle_kmsKeyHandleBasicExample still fails.

[romanini-ciandt]

@zli82016 this error you posted is being discussed/investigated in hashicorp/terraform-provider-google#18935. We suspect that is an infrastructure error (more details are in the issue thread). Looks like it was a flaky and after 8/4/24 it started to fail 100% of the times (for both testAccKMSAutokeyConfig_kmsAutokeyConfigAllExample and testAccKMSKeyHandle_kmsKeyHandleBasicExample).

The goal of this current opened PR is to make the folder name sweepable and fix the hard-coded static folder name error. Do you think we can merge this now and deal with the other error in a future PR, if it's needed? ("if it's needed" because if it's due to some infra issue, maybe no PR here will be required)

PS: In your comment you mentioned that "TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample passed" and "TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample still fails", but both are the same name. Which one passed? Key Handle or Autokey Config?

Thanks!

[zli82016]

@zli82016 this error you posted is being discussed/investigated in hashicorp/terraform-provider-google#18935. We suspect that is an infrastructure error (more details are in the issue thread). Looks like it was a flaky and after 8/4/24 it started to fail 100% of the times (for both testAccKMSAutokeyConfig_kmsAutokeyConfigAllExample and testAccKMSKeyHandle_kmsKeyHandleBasicExample).

The goal of this current opened PR is to make the folder name sweepable and fix the hard-coded static folder name error. Do you think we can merge this now and deal with the other error in a future PR, if it's needed? ("if it's needed" because if it's due to some infra issue, maybe no PR here will be required)

PS: In your comment you mentioned that "TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample passed" and "TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample still fails", but both are the same name. Which one passed? Key Handle or Autokey Config?

Thanks!

oh. Sorry for the copy paste issue.
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample passed.

TestAccKMSKeyHandle_kmsKeyHandleBasicExample failed.

This PR can be merged and then fix the test TestAccKMSKeyHandle_kmsKeyHandleBasicExample in the future.

[zli82016]

But I don't think this PR's change is related to TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample.

[zli82016]

LGTM.