Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM resources to google_compute_instance_template #11932

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

karolgorc
Copy link
Contributor

@karolgorc karolgorc commented Oct 7, 2024

closes hashicorp/terraform-provider-google#7257

region_instance_template doesn't have API methonds to implement it there

Release Note Template for Downstream PRs (will be copied)

`google_compute_instance_template_iam_member`
`google_compute_instance_template_iam_policy`
`google_compute_instance_template_iam_binding`
`google_compute_instance_template_iam_policy`

@github-actions github-actions bot requested a review from BBBmau October 7, 2024 09:26
Copy link

github-actions bot commented Oct 7, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 7, 2024
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 15, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 685 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 685 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 347 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_compute_instance_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1033
Passed tests: 956
Skipped tests: 74
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplateIamBindingGenerated
  • TestAccComputeInstanceTemplateIamMemberGenerated
  • TestAccComputeInstanceTemplateIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplateIamBindingGenerated[Debug log]
TestAccComputeInstanceTemplateIamMemberGenerated[Debug log]
TestAccComputeInstanceTemplateIamPolicyGenerated[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@karolgorc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@karolgorc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@karolgorc karolgorc requested a review from BBBmau November 12, 2024 09:56
@karolgorc
Copy link
Contributor Author

Hi can this get reviewed or reassigned?

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Dec 3, 2024

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@BBBmau
Copy link
Collaborator

BBBmau commented Dec 4, 2024

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 4, 2024
Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 685 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 685 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 347 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_compute_instance_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1075
Passed tests: 1002
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions bot requested a review from BBBmau January 10, 2025 11:21
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 10, 2025
@karolgorc
Copy link
Contributor Author

--- PASS: TestAccComputeInstanceTemplateIamPolicyGenerated_withCondition (24.02s)
--- PASS: TestAccComputeInstanceTemplateIamBindingGenerated_withCondition (34.47s)
--- PASS: TestAccComputeInstanceTemplateIamMemberGenerated (34.63s)
--- PASS: TestAccComputeInstanceTemplateIamMemberGenerated_withCondition (34.75s)
--- PASS: TestAccComputeInstanceTemplateIamPolicyGenerated (35.49s)
--- PASS: TestAccComputeInstanceTemplateIamBindingGenerated (48.84s)
--- PASS: TestAccComputeInstanceTemplateIamBindingGenerated_withAndWithoutCondition (59.81s)
--- PASS: TestAccComputeInstanceTemplateIamMemberGenerated_withAndWithoutCondition (60.15s)
PASS
ok github.com/hashicorp/terraform-provider-google/google/services/compute 60.177s

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 10, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1170 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1170 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 351 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1088
Passed tests: 1007
Skipped tests: 75
Affected tests: 6

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeInstanceTemplateIamBindingGenerated_withAndWithoutCondition
  • TestAccComputeInstanceTemplateIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplateIamBindingGenerated
  • TestAccComputeInstanceTemplateIamBindingGenerated_withCondition
  • TestAccComputeInstanceTemplateIamMemberGenerated
  • TestAccComputeInstanceTemplateIamMemberGenerated_withCondition
  • TestAccComputeInstanceTemplateIamPolicyGenerated
  • TestAccComputeInstanceTemplateIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplateIamBindingGenerated [Debug log]
TestAccComputeInstanceTemplateIamBindingGenerated_withCondition [Debug log]
TestAccComputeInstanceTemplateIamMemberGenerated [Debug log]
TestAccComputeInstanceTemplateIamMemberGenerated_withCondition [Debug log]
TestAccComputeInstanceTemplateIamPolicyGenerated [Debug log]
TestAccComputeInstanceTemplateIamPolicyGenerated_withCondition [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IAM Resources for Instance Templates
3 participants