google_artifact_registry_repository: Fix perma-diff in maven_config

[Subserial]

The maven_config field is immutable, but also optional. This PR adds a diff suppress to equate missing, empty and default configs.

Example:

resource "google_artifact_registry_repository" "repo" {
  project       = local.project_id
  repository_id = "test-maven-repo"
  format        = "MAVEN"
  location      = "us"
  description   = "Test Maven Repository"
}

resource "google_artifact_registry_repository" "repo" {
  project       = local.project_id
  repository_id = "test-maven-repo"
  format        = "MAVEN"
  location      = "us"
  description   = "Test Maven Repository"
  maven_config { }
}

resource "google_artifact_registry_repository" "repo" {
  project       = local.project_id
  repository_id = "test-maven-repo"
  format        = "MAVEN"
  location      = "us"
  description   = "Test Maven Repository"
  maven_config {
    allow_snapshot_overwrites = false
  }
}

These should all represent the same configuration, but instead cause perma-diffs when moving from one to any other.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed perma-diff in `google_artifact_registry_repository`

b/376134092

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 23 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field maven_config.version_policy default value changed from VERSION_POLICY_UNSPECIFIED to on google_artifact_registry_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 23 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field maven_config.version_policy default value changed from VERSION_POLICY_UNSPECIFIED to on google_artifact_registry_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• artifactregistry

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• artifactregistry

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 1 file changed, 22 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• artifactregistry

🟢 All tests passed!

View the build log

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@Subserial, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• artifactregistry

🟢 All tests passed!

View the build log

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[BBBmau]

only ask i have is if you can include this as part of a test. just like what you mentioned in the description of this PR.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 91 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 91 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 31
Passed tests: 29
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• artifactregistry

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccArtifactRegistryRepository_updateEmptyMvn

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRepository_updateEmptyMvn [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[BBBmau]

looks good, apologies for the late reviews!