Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edgenetwork Router resource. #12594

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add edgenetwork Router resource. #12594

wants to merge 7 commits into from

Conversation

f1urps
Copy link
Contributor

@f1urps f1urps commented Dec 17, 2024 •
edited
Loading

Create Router resource in product edgenetwork.

Fixes hashicorp/terraform-provider-google#15666

Tests are disabled for this resource for the same reason as other resources in edgenetwork. See: #8905

This PR depends on another in-review PR: #12586

Release Note Template for Downstream PRs (will be copied)

`google_edgenetwork_router`

@github-actions github-actions bot requested a review from roaks3 December 17, 2024 16:29
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 17, 2024
@github-actions GitHub Actions
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

roaks3
roaks3 reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly needs more testing (unless the resource is immutable), but otherwise LGTM

mmv1/products/edgenetwork/Router.yaml Outdated Show resolved Hide resolved
mmv1/templates/terraform/examples/edgenetwork_router_minimal.tf.tmpl Outdated Show resolved Hide resolved
mmv1/templates/terraform/examples/edgenetwork_router_with_bgp.tf.tmpl Show resolved Hide resolved
@github-actions github-actions bot requested a review from roaks3 December 31, 2024 20:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions bot requested a review from roaks3 January 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 Awaiting requested review from roaks3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Router resource for edgenetwork API
3 participants
@f1urps @roaks3 @modular-magician