Add support for Third Party Identity

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: added `enable_third_party_identity` field to `google_workbench_instance` resource.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[rileykarson]

The API seems to return back false- is the feature enabled API-side, or is there something we're missing here?

        Terraform will perform the following actions:
        
          # google_workbench_instance.instance will be updated in-place
          ~ resource "google_workbench_instance" "instance" {
              ~ enable_third_party_identity = false -> true
                id                          = "projects/my-project/locations/us-central1-a/instances/tf-test-workbench-instance78fhlm3tdh"
                name                        = "tf-test-workbench-instance78fhlm3tdh"
                # (16 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }

[bcreddy-gcp]

API changes to return the field are rolling out. We can re-visit the PR once it is rolled out.

[rileykarson]

Thanks! Just let me know when.

[bcreddy-gcp]

Changes are rolled out. Tests should be passing now.

[bcreddy-gcp]

Doesn't look like they have been rolled out. I'll revisit this when they are.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 43 insertions(+))
google-beta provider: Diff ( 4 files changed, 43 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.