Add support for Updating Container Image

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: Changed `container_Image` field of `google_workbench_instance` resource to modifiable.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 117 insertions(+))
google-beta provider: Diff ( 4 files changed, 117 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateCustomContainers
• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_updateCustomContainers [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 117 insertions(+))
google-beta provider: Diff ( 4 files changed, 117 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateCustomContainers
• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_updateCustomContainers [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SirGitsalot]

LGTM but the reason the tests are failing is that the API change hasn't rolled out yet, we'll want to hold off on this PR until it has.

[github-actions]

@bcreddy-gcp, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 117 insertions(+))
google-beta provider: Diff ( 4 files changed, 117 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[bcreddy-gcp]

API changes are rolled out. Local tests are passing.
--- PASS: TestAccWorkbenchInstance_updateCustomContainers (539.87s)

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateCustomContainers
• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 75 insertions(+))
google-beta provider: Diff ( 2 files changed, 75 insertions(+))

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccWorkbenchInstance_updateCustomContainers [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 22
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log