Add support for parameter manager parameter resource google_parameter_manager_parameter

[abheda-crest]

Add support for parameter manager parameter resource google_parameter_manager_parameter.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_parameter`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

Will parameters ever be location-based? Or are they strictly limited to global forever?

[gptSanyam]

The API is regional and global is considered as a region ( so base URL can be parameterised)
However the URL for global and regional API endpoints vary:
Global: parametermanager.googleapis.com
Regional: parametermanager.**{location}.rep.**googleapis.com

@slevenick Just because of this we will have to make keep regional and global resources. Can these be combined?

[slevenick]

Hmmmm, does the regional endpoint work for global? Like parametermanager.**global.rep.**googleapis.com?

If so, it should be easy to regionalize it now and allow global as a region.

Otherwise it should be possible, but may require some special casing. A lot of it depends on how you want to surface these resources to customers. Should they be separate resources in Terraform or not?

[gptSanyam]

Does the regional endpoint work for global? Like parametermanager.**global.rep.**googleapis.com?

• It will not for global only parametermanager.googleapis.com will work

@slevenick Regarding separate resources: Given that we don't have any change in logic, I don't have a strong reason why we should have separate resources apart from segregating the endpoints.

[slevenick]

We could do switching of the endpoint based on the value of a location field to combine the resources. We would need to make that decision now though, so we should discuss.

Such an approach would complicate use of custom endpoints for this resource though, so we may need to accommodate that somehow

[gptSanyam]

As discussed offline we will continue with having separate resources for global and regional Parameters and Parameter Versions.

[melinath]

It looks like the regional variants may need to be handwritten per hashicorp/terraform-provider-google#12738 (comment)

[melinath]

making a regional variant product folder might be easier.

[abheda-crest]

@melinath We have already created a separate regional product folder along with the equivalent regional resource and this has been merged as a part of the PR #12631

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1220 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 321 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4379
Passed tests: 3949
Skipped tests: 421
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccParameterManagerParameter_import
• TestAccParameterManagerParameter_labelsUpdate
• TestAccParameterManagerParameter_parameterConfigBasicExample
• TestAccParameterManagerParameter_parameterWithFormatExample
• TestAccParameterManagerParameter_parameterWithLabelsExample
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccParameterManagerParameter_import [Error message] [Debug log]
TestAccParameterManagerParameter_labelsUpdate [Error message] [Debug log]
TestAccParameterManagerParameter_parameterConfigBasicExample [Error message] [Debug log]
TestAccParameterManagerParameter_parameterWithFormatExample [Error message] [Debug log]
TestAccParameterManagerParameter_parameterWithLabelsExample [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[slevenick]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1220 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 321 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4387
Passed tests: 3950
Skipped tests: 429
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccParameterManagerParameter_import
• TestAccParameterManagerParameter_labelsUpdate
• TestAccParameterManagerParameter_parameterConfigBasicExample
• TestAccParameterManagerParameter_parameterWithFormatExample
• TestAccParameterManagerParameter_parameterWithLabelsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccParameterManagerParameter_import [Debug log]
TestAccParameterManagerParameter_labelsUpdate [Debug log]
TestAccParameterManagerParameter_parameterConfigBasicExample [Debug log]
TestAccParameterManagerParameter_parameterWithFormatExample [Debug log]
TestAccParameterManagerParameter_parameterWithLabelsExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+))
google-beta provider: Diff ( 12 files changed, 1232 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4389
Passed tests: 3957
Skipped tests: 429
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[abheda-crest]

@slevenick Could you please review this PR?

[abheda-crest]

@BBBmau Could you please review this PR?
Note: This PR is equivalent global resource for the PR #12631 that you reviewed and merged yesterday.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+))
google-beta provider: Diff ( 12 files changed, 1232 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4421
Passed tests: 3987
Skipped tests: 429
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccDataSourceGoogleQuotaInfo_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

Assigning a new reviewer, as the original reviewer is OOO

[shuyama1]

@modular-magician reassign-reviewer

[melinath]

A couple small questions/changes but overall LGTM

[melinath]

Is this default expected to be stable over time? If so, it would be a slightly better UX to use default_value rather than default_from_api. More info at https://googlecloudplatform.github.io/magic-modules/develop/diffs/#default.

[abheda-crest]

Is this default expected to be stable over time?

What do you think @gptSanyam?

If so, it would be a slightly better UX to use default_value rather than default_from_api. More info at https://googlecloudplatform.github.io/magic-modules/develop/diffs/#default.

However, AFAIK, default values are being sent in the request body itself. So, I think it would be better that the field is optional + computed. @melinath Let me know your thoughts.

[melinath]

What is the problem with sending default values in the request body? That is also what happens if a user sets a value.

[abheda-crest]

I think if in future the default from the API side changes than it would require the change to be done in the provider too.

[abheda-crest]

But, Yeah, I agree with your point that if default from the API is going to stable than we can also use the default values.

[melinath]

Let's just leave this as default_from_api since the regional variant was already merged with that. For future reference, default_value is preferred where possible for the reasons listed above, but it's not the end of the world to use default_from_api instead.

[gptSanyam]

Thanks @melinath
I can't think of a scenario where the default value will change.

So my recommendation is to change this to default value.
@abheda-crest we will need to fix this in the regional resource as well - which is already merged.

[melinath]

Okay, SGTM - the other resource was merged on Wednesday so it should still be safe to change that.

[abheda-crest]

@melinath I've used default_value as UNFORMATTED instead of default_from_api for both google_parameter_manager_parameter and google_parameter_manager_regional_parameter resource.

[melinath]

I think this fully duplicates the generated TestAccParameterManagerParameter_parameterWithLabelsExample: https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-12630-old..auto-pr-12630#diff-ff73922eed881cfc98b75567279d475bd05f6cd8163cb65d6d07ca6cc86309c1R102

Suggested change

	func TestAccParameterManagerParameter_import(t *testing.T) {
	t.Parallel()
	context := map[string]interface{}{
	"random_suffix": acctest.RandString(t, 10),
	}
	acctest.VcrTest(t, resource.TestCase{
	PreCheck: func() { acctest.AccTestPreCheck(t) },
	ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
	CheckDestroy: testAccCheckParameterManagerParameterDestroyProducer(t),
	Steps: []resource.TestStep{
	{
	Config: testAccParameterManagerParameter_import(context),
	},
	{
	ResourceName: "google_parameter_manager_parameter.parameter-import",
	ImportState: true,
	ImportStateVerify: true,
	ImportStateVerifyIgnore: []string{"labels", "parameter_id", "terraform_labels"},
	},
	},
	})
	}
	func testAccParameterManagerParameter_import(context map[string]interface{}) string {
	return acctest.Nprintf(`
	resource "google_parameter_manager_parameter" "parameter-import" {
	provider = google-beta
	parameter_id = "tf_test_parameter%{random_suffix}"
	format = "YAML"
	labels = {
	key1 = "val1"
	key2 = "val2"
	key3 = "val3"
	key4 = "val4"
	key5 = "val5"
	}
	}
	`, context)
	}

[abheda-crest]

Done.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 217 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1194 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field format default value changed from to UNFORMATTED on google_parameter_manager_regional_parameter - reference
• Field format transitioned from optional+computed to optional google_parameter_manager_regional_parameter - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 217 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1194 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field format default value changed from to UNFORMATTED on google_parameter_manager_regional_parameter - reference
• Field format transitioned from optional+computed to optional google_parameter_manager_regional_parameter - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 4425
Passed tests: 3988
Skipped tests: 429
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccParameterManagerParameter_parameterConfigBasicExample
• TestAccParameterManagerParameter_parameterWithLabelsExample
• TestAccParameterManagerRegionalRegionalParameter_regionalParameterBasicExample
• TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithLabelsExample
• TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccParameterManagerParameter_parameterConfigBasicExample [Debug log]
TestAccParameterManagerParameter_parameterWithLabelsExample [Debug log]
TestAccParameterManagerRegionalRegionalParameter_regionalParameterBasicExample [Debug log]
TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithLabelsExample [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

LGTM

[melinath]

test failures are unrelated