Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager regional parameter version resource google_parameter_manager_regional_parameter_version #12642

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

abheda-crest
Copy link
Contributor

Add support for parameter manager regional parameter version resource google_parameter_manager_regional_parameter_version.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Note: This PR is dependent upon the parameter manager regional parameter resource which will be added as a part of the PR #12631

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_regional_parameter_version`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 23, 2024
@abheda-crest abheda-crest force-pushed the parameter-manager-regional-parameter-version-resource-support branch from 348c9b8 to 5bf5c75 Compare December 31, 2024 09:08
@abheda-crest abheda-crest marked this pull request as ready for review January 9, 2025 05:37
Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge January 9, 2025 05:38
@abheda-crest
Copy link
Contributor Author

I've attached screenshot for the local test run for the test cases for google_parameter_manager_regional_parameter_version resource:

image

@abheda-crest
Copy link
Contributor Author

@trodge Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants