Support Swithcover for MySQL and PostgreSQL #12646

lychgoogle · 2024-12-24T02:53:33Z

References
- issue: Implement new cloud SQL API switchover hashicorp/terraform-provider-google#18807
- work for SQL server: Support SQL Server Switchover (after resolving email rebase conflicts) #12241
- design (google only): go/speckle-switchover-terraform-proposal
Implementation
- main change: adding replication_cluster: just copied corresponding filed from API. https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/instances#resource:-databaseinstance . dr_replica is read only, and failover_dr_replica_name is optionally set by customer. To support "deletion" of optional computed resource, we use "NON_EXISTENT" as placeholder for non-existent failover_dr_replica_name in terraform.
- isSwitchoverRequested(): just removed restriction on the database type.
- isSwitchoverFromOldPrimarySide() also removed restriction on the database type, and checking isCascadableReplica only for SQL server (because this concept is SQL server specific).
- nit: when handling error from PromoteReplica/Swithcover, we use d.Get("name") instead of instance.Name which returns nullptr error.
Tests
- Added VCR tests for MySQL and PostgreSQL. They exercise end-to-end switchover CUJ.
- Also verified that setting/unsetting failover_dr_replica_name to validate that "NON_EXISTENT" works correctly.
Docs
- most of changes are in mmv1/third_party/terraform/website/docs/guides/sql_instance_switchover.html.markdown I added new sections for MySQL and PostgreSQL
- changes in mmv1/third_party/terraform/website/docs/r/sql_database_instance.html.markdown are minimal, just basic information about added fields, and summary of switchover.

Release Note Template for Downstream PRs (will be copied)

sql: added `replication_cluster` field to `google_sql_database_instance` resource

sql: added support of switchover for MySQL and PostgreSQL in `google_sql_database_instance` resource

github-actions · 2024-12-24T02:54:16Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-12-24T03:04:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1188 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 4 files changed, 1188 insertions(+), 22 deletions(-))

modular-magician · 2024-12-24T03:07:51Z

Tests analytics

Total tests: 106
Passed tests: 61
Skipped tests: 15
Affected tests: 30

Click here to see the affected service packages

sql

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2024-12-24T03:48:06Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

github-actions · 2024-12-26T09:40:52Z

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

zli82016 · 2024-12-27T01:07:03Z

It looks like the switchover method is not called from Terraform provider. Is this method called in API side to complete the switchover operation?

lychgoogle · 2024-12-27T18:59:56Z

It looks like the switchover method is not called from Terraform provider. Is this method called in API side to complete the switchover operation?

I'm not familiar with terraform (still), but the API is called from the provider code

magic-modules/mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

Lines 1962 to 1964 in 890855b

    
           retryFunc = func() (rerr error) { 
        
           	op, rerr = config.NewSqlAdminClient(userAgent).Instances.Switchover(project, d.Get("name").(string)).Do() 
        
           	return rerr

lychgoogle · 2024-12-27T19:29:37Z

@zli82016 I briefly replied to all of your comment. PTAL

zli82016

I added some comments. Let me know if you have questions.

lychgoogle · 2025-01-03T19:32:10Z

I added some comments. Let me know if you have questions.

@zli82016 I briefly replied to all of your comment. PTAL

I'm currently fixing test. As side affect of setting replication_cluster as Computed: false, I have to set ExpectNonEmptyPlan: true for many test steps. This is because replication_cluster (and many other fields) of googld_sql_database_instance can be changed without updating it directly, but by updating another googld_sql_database_instance.

If ExpectNonEmptyPlan: true is OK, then I'll continue work on tests. (and also public docs)

zli82016 · 2025-01-03T19:35:22Z

replication_cluster

Sorry to hear that. Do you have the logs for the test that the plan is not empty?

lychgoogle · 2025-01-03T23:19:22Z

replication_cluster

Sorry to hear that. Do you have the logs for the test that the plan is not empty?

I'm still not familiar with terraform (this is first big change I'm making), the first (and probably the biggest) problem I'm having is following: (All manual tests are done after reflecting your suggestion)

We have main.tf as follows (and corresponding resource in cloud SQL backend).

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  replication_cluster {
    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

We make following change to "original primary", and issue "terraform apply"

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

-  replication_cluster {
-    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
-  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

But update operation of "original-primary" removes "original-replica"'s replication_cluster (it is intended in cloud SQL), so I want to delete that in main.tf also.

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

-  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

However terrafrom plan shows following "1 to change"

Terraform will perform the following actions:

  # google_sql_database_instance.original-replica will be updated in-place
  ~ resource "google_sql_database_instance" "original-replica" {
        id                             = "tf-test-2025-01-03-prim-1-rep-1"
        name                           = "tf-test-2025-01-03-prim-1-rep-1"
        # (19 unchanged attributes hidden)

      - replication_cluster {
          - dr_replica               = true -> null
            # (1 unchanged attribute hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

probably related warning message

2025-01-03T15:14:17.285-0800 [WARN]  Provider "registry.terraform.io/hashicorp/google-beta" produced an invalid plan for google_sql_database_instance.original-replica, but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      # irrelevant details omitted...
      - .replica_configuration: block count in plan (1) disagrees with count in config (0)

From my understanding, fixing "original-replica" should be done by modifying main.tf, and running "terraform plan" and check that there's no change needed. (I'm following #12241 which is really similar work as I'm doing now)

zli82016 · 2025-01-03T23:40:27Z

replication_cluster

Sorry to hear that. Do you have the logs for the test that the plan is not empty?

I'm still not familiar with terraform (this is first big change I'm making), the first (and probably the biggest) problem I'm having is following: (All manual tests are done after reflecting your suggestion)

We have main.tf as follows (and corresponding resource in cloud SQL backend).

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  replication_cluster {
    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

We make following change to "original primary", and issue "terraform apply"

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

-  replication_cluster {
-    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
-  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

But update operation of "original-primary" removes "original-replica"'s replication_cluster (it is intended in cloud SQL), so I want to delete that in main.tf also.

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

-  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

However terrafrom plan shows following "1 to change"

Terraform will perform the following actions:

  # google_sql_database_instance.original-replica will be updated in-place
  ~ resource "google_sql_database_instance" "original-replica" {
        id                             = "tf-test-2025-01-03-prim-1-rep-1"
        name                           = "tf-test-2025-01-03-prim-1-rep-1"
        # (19 unchanged attributes hidden)

      - replication_cluster {
          - dr_replica               = true -> null
            # (1 unchanged attribute hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

probably related warning message

2025-01-03T15:14:17.285-0800 [WARN]  Provider "registry.terraform.io/hashicorp/google-beta" produced an invalid plan for google_sql_database_instance.original-replica, but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      # irrelevant details omitted...
      - .replica_configuration: block count in plan (1) disagrees with count in config (0)

From my understanding, fixing "original-replica" should be done by modifying main.tf, and running "terraform plan" and check that there's no change needed. (I'm following #12241 which is really similar work as I'm doing now)

Thank you for providing the information. It looks like update operation of original-primary doesn't remove original-replica's replication_cluster in step 3. The original-replica's replication_cluster has dr_replica = true. Do you have an idea what is going on here? I doubt if the API returns the value of dr_replica. Is it expected?

lychgoogle · 2025-01-04T03:18:25Z

replication_cluster

Sorry to hear that. Do you have the logs for the test that the plan is not empty?

I'm still not familiar with terraform (this is first big change I'm making), the first (and probably the biggest) problem I'm having is following: (All manual tests are done after reflecting your suggestion)

We have main.tf as follows (and corresponding resource in cloud SQL backend).

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  replication_cluster {
    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

We make following change to "original primary", and issue "terraform apply"

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

-  replication_cluster {
-    failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
-  }

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

But update operation of "original-primary" removes "original-replica"'s replication_cluster (it is intended in cloud SQL), so I want to delete that in main.tf also.

resource "google_sql_database_instance" "original-primary" {
  provider            = google-beta
  project             = "lych-dev-plg-1"
  name                = "tf-test-2025-01-03-prim-1"
  region              = "us-east1"
  database_version    = "MYSQL_8_0"
  instance_type       = "CLOUD_SQL_INSTANCE"
  deletion_protection = false

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
    backup_configuration {
      enabled            = true
      binary_log_enabled = true
    }
  }
}

resource "google_sql_database_instance" "original-replica" {
  provider             = google-beta
  project              = "lych-dev-plg-1"
  name                 = "tf-test-2025-01-03-prim-1-rep-1"
  region               = "us-west2"
  database_version     = "MYSQL_8_0"
  instance_type        = "READ_REPLICA_INSTANCE"
  master_instance_name = google_sql_database_instance.original-primary.name
  deletion_protection  = false

-  replication_cluster {}

  settings {
    tier    = "db-perf-optimized-N-2"
    edition = "ENTERPRISE_PLUS"
  }
}

However terrafrom plan shows following "1 to change"

Terraform will perform the following actions:

  # google_sql_database_instance.original-replica will be updated in-place
  ~ resource "google_sql_database_instance" "original-replica" {
        id                             = "tf-test-2025-01-03-prim-1-rep-1"
        name                           = "tf-test-2025-01-03-prim-1-rep-1"
        # (19 unchanged attributes hidden)

      - replication_cluster {
          - dr_replica               = true -> null
            # (1 unchanged attribute hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

probably related warning message

2025-01-03T15:14:17.285-0800 [WARN]  Provider "registry.terraform.io/hashicorp/google-beta" produced an invalid plan for google_sql_database_instance.original-replica, but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      # irrelevant details omitted...
      - .replica_configuration: block count in plan (1) disagrees with count in config (0)

From my understanding, fixing "original-replica" should be done by modifying main.tf, and running "terraform plan" and check that there's no change needed. (I'm following #12241 which is really similar work as I'm doing now)

Thank you for providing the information. It looks like update operation of original-primary doesn't remove original-replica's replication_cluster in step 3. The original-replica's replication_cluster has dr_replica = true. Do you have an idea what is going on here? I doubt if the API returns the value of dr_replica. Is it expected?

(Again my answer is probably wrong about terraform)

for reference, I published unfinished commit that I'm working on bd4c2df

To me the problem is that step 3 triggers the update operation, where it shouldn't at all. My expectation is that terraform plan results in No changes. Your infrastructure matches the configuration. .
From purely backend logic, following happens at the time of execution of 2.

cloud SQL's update operation on "original-primary" changes both "original-primary" and "original-replica"

"original-primary".replication_cluster:

before:

replication_cluster {
  failover_dr_replica_name = "lych-dev-plg-1:tf-test-2025-01-03-prim-1-rep-1"
  dr_replica = false
}

after: non-present

"original-replica".replication_cluster:

before:

replication_cluster {
  dr_replica = true
}

after: non-present

So after step 2, change on main.tf should be a no-op, just reflecting change happened on step 2 (at least this is what I want)

for the field dr_replica, this is always read-only value, which cloud SQL backend computes, and my implementation is also in that way. Following is the code I'm experimenting right now.

func flattenReplicationCluster(replicationCluster *sqladmin.ReplicationCluster, d *schema.ResourceData) []map[string]interface{} {
        data := make(map[string]interface{})
        if replicationCluster.FailoverDrReplicaName != "" {
                data["failover_dr_replica_name"] = replicationCluster.FailoverDrReplicaName
        }
        data["dr_replica"] = replicationCluster.DrReplica
        return []map[string]interface{}{data}
}

modular-magician · 2025-01-04T03:28:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1242 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 4 files changed, 1242 insertions(+), 22 deletions(-))

modular-magician · 2025-01-04T03:32:21Z

Tests analytics

Total tests: 106
Passed tests: 61
Skipped tests: 15
Affected tests: 30

Click here to see the affected service packages

sql

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2025-01-04T04:15:49Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go

modular-magician · 2025-01-10T04:50:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1188 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 4 files changed, 1188 insertions(+), 22 deletions(-))

modular-magician · 2025-01-10T04:53:38Z

Tests analytics

Total tests: 106
Passed tests: 61
Skipped tests: 15
Affected tests: 30

Click here to see the affected service packages

sql

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2025-01-10T05:41:12Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…dification Fix after review 1

lychgoogle · 2025-01-10T06:55:27Z

Hello @zli82016 I applied all changes we discussed in offline. PTAL

modular-magician · 2025-01-10T06:58:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1182 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 4 files changed, 1182 insertions(+), 22 deletions(-))

modular-magician · 2025-01-10T07:02:41Z

Tests analytics

Total tests: 106
Passed tests: 57
Skipped tests: 15
Affected tests: 34

Click here to see the affected service packages

sql

Action taken

Found 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2025-01-10T07:58:46Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataSourceSqlDatabaseInstances_basic [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_tierFilter [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

Fix after review 2: Remove NON_EXISTENT

modular-magician · 2025-01-10T21:28:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1174 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 4 files changed, 1174 insertions(+), 22 deletions(-))

modular-magician · 2025-01-10T21:32:43Z

Tests analytics

Total tests: 106
Passed tests: 87
Skipped tests: 15
Affected tests: 4

Click here to see the affected service packages

sql

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

Get to know how VCR tests work

modular-magician · 2025-01-10T21:53:58Z

🔴 Tests failed during RECORDING mode:
TestAccDataSourceSqlDatabaseInstances_basic [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter [Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_tierFilter [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Add replication_cluster to instances list

modular-magician · 2025-01-10T23:49:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1191 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 1191 insertions(+), 22 deletions(-))

modular-magician · 2025-01-10T23:53:15Z

Tests analytics

Total tests: 106
Passed tests: 91
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages

sql

🟢 All tests passed!

View the build log

zli82016

LGTM

switchover-for-mysql-and-postgres

a0f4d0b

github-actions bot requested a review from zli82016 December 24, 2024 02:54

modular-magician added the service/sqladmin-cp label Dec 24, 2024

zli82016 requested changes Dec 27, 2024

View reviewed changes

github-actions bot requested a review from zli82016 December 27, 2024 19:00

zli82016 requested changes Jan 3, 2025

View reviewed changes

github-actions bot requested a review from zli82016 January 3, 2025 19:32

zli82016 requested changes Jan 6, 2025

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl Show resolved Hide resolved

mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved

zli82016 requested changes Jan 7, 2025

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go Outdated Show resolved Hide resolved

lychgoogle force-pushed the switchover-2024-12-18 branch from bd4c2df to a0f4d0b Compare January 10, 2025 04:38

github-actions bot requested a review from zli82016 January 10, 2025 04:39

lychgoogle added 2 commits January 9, 2025 22:35

Fix after review 1

bc47619

Merge pull request #1 from lychgoogle/switchover-2024-12-18-manual-mo…

caa84a0

…dification Fix after review 1

zli82016 reviewed Jan 10, 2025

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl Outdated Show resolved Hide resolved

lychgoogle added 2 commits January 10, 2025 13:12

Fix after review 2: Remove NON_EXISTENT

021d78d

Merge pull request #2 from lychgoogle/switchover-2024-12-18-review-2

1f143bb

Fix after review 2: Remove NON_EXISTENT

github-actions bot requested a review from zli82016 January 10, 2025 21:18

lychgoogle added 2 commits January 10, 2025 15:36

Add replication_cluster to instances list

443d97e

Merge pull request #3 from lychgoogle/switchover-2024-12-18-review-2

622d396

Add replication_cluster to instances list

zli82016 approved these changes Jan 11, 2025

View reviewed changes

zli82016 merged commit 06d9610 into GoogleCloudPlatform:main Jan 11, 2025
15 checks passed

bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025

Support Swithcover for MySQL and PostgreSQL (GoogleCloudPlatform#12646)

c44e1f1

bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025

Support Swithcover for MySQL and PostgreSQL (GoogleCloudPlatform#12646)

06a0295

lychgoogle deleted the switchover-2024-12-18 branch January 13, 2025 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Swithcover for MySQL and PostgreSQL #12646

Support Swithcover for MySQL and PostgreSQL #12646

lychgoogle commented Dec 24, 2024 •

edited by zli82016

Loading

github-actions bot commented Dec 24, 2024

modular-magician commented Dec 24, 2024

modular-magician commented Dec 24, 2024

modular-magician commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

zli82016 commented Dec 27, 2024

lychgoogle commented Dec 27, 2024

lychgoogle commented Dec 27, 2024

zli82016 left a comment

lychgoogle commented Jan 3, 2025

zli82016 commented Jan 3, 2025 •

edited

Loading

lychgoogle commented Jan 3, 2025

zli82016 commented Jan 3, 2025 •

edited

Loading

lychgoogle commented Jan 4, 2025 •

edited

Loading

modular-magician commented Jan 4, 2025

modular-magician commented Jan 4, 2025

modular-magician commented Jan 4, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

lychgoogle commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

zli82016 left a comment

Support Swithcover for MySQL and PostgreSQL #12646

Support Swithcover for MySQL and PostgreSQL #12646

Conversation

lychgoogle commented Dec 24, 2024 • edited by zli82016 Loading

github-actions bot commented Dec 24, 2024

modular-magician commented Dec 24, 2024

Diff report

modular-magician commented Dec 24, 2024

Tests analytics

Action taken

modular-magician commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

zli82016 commented Dec 27, 2024

lychgoogle commented Dec 27, 2024

lychgoogle commented Dec 27, 2024

zli82016 left a comment

Choose a reason for hiding this comment

lychgoogle commented Jan 3, 2025

zli82016 commented Jan 3, 2025 • edited Loading

lychgoogle commented Jan 3, 2025

zli82016 commented Jan 3, 2025 • edited Loading

lychgoogle commented Jan 4, 2025 • edited Loading

modular-magician commented Jan 4, 2025

Diff report

modular-magician commented Jan 4, 2025

Tests analytics

Action taken

modular-magician commented Jan 4, 2025

modular-magician commented Jan 10, 2025

Diff report

modular-magician commented Jan 10, 2025

Tests analytics

Action taken

modular-magician commented Jan 10, 2025

lychgoogle commented Jan 10, 2025

modular-magician commented Jan 10, 2025

Diff report

modular-magician commented Jan 10, 2025

Tests analytics

Action taken

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

Diff report

modular-magician commented Jan 10, 2025

Tests analytics

Action taken

modular-magician commented Jan 10, 2025

modular-magician commented Jan 10, 2025

Diff report

modular-magician commented Jan 10, 2025

Tests analytics

zli82016 left a comment

Choose a reason for hiding this comment

lychgoogle commented Dec 24, 2024 •

edited by zli82016

Loading

zli82016 commented Jan 3, 2025 •

edited

Loading

zli82016 commented Jan 3, 2025 •

edited

Loading

lychgoogle commented Jan 4, 2025 •

edited

Loading