Add post_read custom_code

[coder-221]

This is to unblock a future PR for etags in access_context_manager resources. We'll need to access the etag in the GET response that's made from the nested_query code. For consistency, I also added the post_read to the normal resource read function as well, but that's not strictly required for our use case.

I'm also not sure what the params false - are for in the template, so would appreciate a check to ensure those are correct. Thanks!

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 13 deletions(-))
google-beta provider: Diff ( 13 files changed, 13 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 13 deletions(-))
google-beta provider: Diff ( 13 files changed, 13 deletions(-))

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 13 deletions(-))
google-beta provider: Diff ( 13 files changed, 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1208
Passed tests: 1125
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages

• accesscontextmanager
• bigquery
• compute

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 1208
Passed tests: 1125
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages

• bigquery
• compute
• accesscontextmanager

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 1208
Passed tests: 1124
Skipped tests: 83
Affected tests: 1

Click here to see the affected service packages

• accesscontextmanager
• bigquery
• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[c2thorn]

Can you provide an example template and use it with post_read in some resource's YAML file so we can see that its working?

The template can just add dummy comments so it won't have any functional change to the resource

[c2thorn]

the CustomTemplate function is from here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/api/resource.go#L1510

the false will toggle off the option for appending a new line - a feature we really only cared about for an older migration and should not be relevant either way for you

the - tells the go template to delete any whitespace after the statement. Getting an example working with this should show how that ends up looking

[coder-221]

Can you provide an example template and use it with post_read in some resource's YAML file so we can see that its working?

The template can just add dummy comments so it won't have any functional change to the resource

Done and thanks for the review! I added a post_read template to one of the ACM resources and checked the generated output. I can see both places where it inserted the code comments from the template and I think it looks correct

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 7 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 13 files changed, 7 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1208
Passed tests: 1125
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages

• accesscontextmanager
• bigquery
• compute

🟢 All tests passed!

View the build log

[c2thorn]

Exactly what I wanted to see. Generated output looks good, so looks like post_read is good to go. Thanks @coder-221 !