Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for keyhandle list #12708

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

nb-goog
Copy link
Contributor

@nb-goog nb-goog commented Jan 8, 2025

Adding DataSource for ListKeyHandle: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/kms_key_handle

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_kms_key_handles`

@github-actions github-actions bot requested a review from trodge January 8, 2025 06:56
Copy link

github-actions bot commented Jan 8, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@nb-goog nb-goog changed the title [Do not review]Add data source for keyhandle list Add data source for keyhandle list Jan 17, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 169 insertions(+))
google-beta provider: Diff ( 3 files changed, 239 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 39
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • kms

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 228 insertions(+))
google-beta provider: Diff ( 4 files changed, 298 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 228 insertions(+))
google-beta provider: Diff ( 4 files changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 39
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • kms

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 39
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • kms

🟢 All tests passed!

View the build log

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants