Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags field to Filestore Instances for TagsR2401 #12712

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aniket-gupta
Copy link
Contributor

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/364841739

filestore: added `tags` field to `filstore_instance` to allow setting tags for instances at creation time
The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

@github-actions github-actions bot requested a review from NickElliot January 8, 2025 20:08
Copy link

github-actions bot commented Jan 8, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_tags

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_tags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_tags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_tags [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 100 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • filestore

🟢 All tests passed!

View the build log

@aniket-gupta
Copy link
Contributor Author

@NickElliot Could you please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants