Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_project to v6 cai2hcl #12713

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 8, 2025

In magic modules, generate tgc

make tgc  OUTPUT_PATH="$GOPATH/src/github.com/GoogleCloudPlatform/terraform-google-conversion"

In terraform-google-conversion

make build
./bin/tgc cai2hcl convert TestAccProject_create.json

output

resource "google_project" "tf-test-872899419570852129" {
  name       = "tf-test-872899419570852129"
  org_id     = "529579013760"
  project_id = "tf-test-872899419570852129"
}

TestAccProject_create.json is in here

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 95 insertions(+), 1 deletion(-))

@zli82016 zli82016 marked this pull request as ready for review January 8, 2025 21:22
@zli82016 zli82016 requested a review from c2thorn January 8, 2025 21:24
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be tests for this eventually?

@zli82016
Copy link
Member Author

zli82016 commented Jan 8, 2025

will there be tests for this eventually?

Yes, there will be automatic testings for this after the testing framework is implemented.

@zli82016
Copy link
Member Author

zli82016 commented Jan 8, 2025

cc @hao-nan-li

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 95 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants