Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccComputeInterconnect_computeInterconnectBasicTestExample #12718

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

akshat-jindal-nit
Copy link
Contributor

@akshat-jindal-nit akshat-jindal-nit commented Jan 9, 2025

b/362278333

fixes hashicorp/terraform-provider-google#19229

Fix for the interconnect test cases by adding different interconnect locations z2z-us-east4-zone1-lciadl-z and z2z-us-east4-zone1-nciadf-a while creating interconnect.

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from trodge January 9, 2025 08:56
Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 9, 2025
@c2thorn c2thorn requested review from c2thorn and removed request for trodge January 9, 2025 16:25
@modular-magician modular-magician added service/compute-interconnect and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 9, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1080
Passed tests: 1004
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample
  • TestAccComputeInterconnect_computeInterconnectMacsecTest
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeInterconnect_computeInterconnectBasicTestExample
3 participants