Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example of usage of Authz Policy #12724

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Samir-Cit
Copy link
Contributor

Hello folks,
This PR is to update the example of usage of the Authz Policy resource (google_network_security_authz_policy) by adding the callouts and the http rules.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from zli82016 January 9, 2025 22:27
Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 9, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 204 insertions(+))
google-beta provider: Diff ( 2 files changed, 204 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 44
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants