Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage_organization_management_hub resource. #12727

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kautikdk
Copy link
Member

This PR adds support for GCS Management Hub on Organization level.

Related Issue(Doesn't fix): hashicorp/terraform-provider-google#20763

`google_storage_organization_management_hub`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 546 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 117
Passed tests: 106
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages
  • storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageOrganizationManagementHub_update
  • TestAccStorageProjectManagementHub_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageOrganizationManagementHub_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccStorageProjectManagementHub_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 546 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 117
Passed tests: 107
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageProjectManagementHub_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageProjectManagementHub_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 2423 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 546 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 117
Passed tests: 108
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants