#338 - branch dan-fix-versions-upgrade - Fixed Provider bugs, TF upgrade. from v1.0.10 to v1.6.0 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@obriensystems let me know if you want me to add more information to the PR, or test screen shots or results. |
danishkamili
changed the title
|
The pr looks good. |
fmichaelobrien
approved these changes
Nov 7, 2023
|
@fmichaelobrien |
|
Very nice. Let me know if you don't see the merge button - but I think you do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Provider Bug for effective labels
[https://github.com/hashicorp/terraform-provider-google/issues/16217]
Upgraded Terraform version - removed dependency on optional experimental features
[https://developer.hashicorp.com/terraform/language/v1.3.x/upgrade-guides#concluding-the-optional-attributes-experiment]
Currently Tested and live in lab at -
terraform version
Terraform v1.6.0
on linux_amd64
Provider: >=3.50
Since, terraform version upgrade requires all the dependent files like root or child modules to be compatible, hence, doing small chunks for fixing provider bugs or upgrades didn't seem feasible, hence, a single PR for the both.
Modules touched mainly:
Cloudbuild
audit-bunker
landing-zone-bootstrap
logging-center
22-private-service-connect
All the
variable.tf which included experimental features
terraform.tf which had downgraded version as well optional feature
let me know if more information is needed or the testing on your end yields a different results or issues.