-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple URLs in sources #134
feat: support multiple URLs in sources #134
Conversation
You need a rebase here; so far looks okay to me. |
767ab63
to
994b756
Compare
This commit fixes the buildifier issues. I'll make the changes to the lock now. |
@thesayyn thinking more about the lockfile, I was considering the "breaking change" and wondering if you would want / prefer the approach I did in #95: supporting If so, maybe you could consider (1) landing this PR as-is and (2) either checking the last comments I did on #93 so I could move that forward and then add the I'm just thinking that it would be nice to avoid the breaking change... let me know what you think! |
Since we are pre 1.0 i'd be okay with just breaking things, that said maybe we could be less sensitive about |
true, true, sounds like a good compromise for now, I think! Same way the manifest can have both... OK, I'll go about this and we can go over the other PRs later on (ah, that huge stack... I would definitely do things differently now XXD) |
994b756
to
d6b2868
Compare
@thesayyn I've added |
d6b2868
to
a4767ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small nit
Fixes GoogleContainerTools#113 The Debian snapshot mirror fails quite often and, while the Cloudflare mirror has had some issues in the past (e.g. it was lagging replication for months) it's much more reliable. This commit adds support for multiple URLs in the manifest and the lockfile. See examples/debian_snapshot/bullseye.yaml for a sample usage.
a4767ce
to
3a883cf
Compare
Fixes #113
The Debian snapshot mirror fails quite often and, while the Cloudflare mirror has had some issues in the past (e.g. it was lagging replication for months) it's much more reliable.
This commit adds support for multiple URLs in the manifest. See examples/debian_snapshot/bullseye.yaml for a sample usage.