Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #121 #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jjmaestro
Copy link
Contributor

In #121 I introduced new aliases and when using one of them (:data) in cacerts, we are hitting the new selects that only have Linux branches and no default case, so it breaks in non-linux OSes.

The cacerts rule needs to be restricted to only compatible OSes.

PR GoogleContainerTools#121 introduced new aliases and when using one of them (`:data`) in
`cacerts`, we are hitting the new `select`s that only have Linux
branches and no default case, so it breaks in non-linux OSes.

The `cacerts` rule needs to be restricted to only compatible OSes.
@jjmaestro
Copy link
Contributor Author

@thesayyn I just noticed the error when I rebased and was trying to repro / check #139 running the tests in OSX. I thought CI was running checks for MacOS too, is that not the case? :-?

@jjmaestro
Copy link
Contributor Author

If I'm reading this correctly, the CI is only excluding Windows:

exclude: |
[
{"folder": ".", "bzlmodEnabled": false},
{"os": "windows-latest"},
]

But looking at the last CI run in #121 it seems like the matrix step only picked Ubuntu and skipped Mac and Windows... maybe it's because the runner only scheduled it in a linux server? :-?

Dunno, GH Actions are a bit hard to debug... in any case, this fixes the issue with the tests, but it would be good to find out if the CI is running everywhere it should!

@jjmaestro
Copy link
Contributor Author

I see the CI ran on MacOS but only after the merge! Is that how it's configured? :-?

@thesayyn
Copy link
Collaborator

I see the CI ran on MacOS but only after the merge! Is that how it's configured? :-?

it only runs on main, and branch names that contain mac since mac runners are expensive.

@jjmaestro
Copy link
Contributor Author

I see the CI ran on MacOS but only after the merge! Is that how it's configured? :-?

it only runs on main, and branch names that contain mac since mac runners are expensive.

Ah, I see. I seem to remember this same discussion before. I think the holidays erased a bunch of context from my head... 😅

Anyway, if you have a Mac and if you want, give it a check just to confirm that it's OK and passing everything! And/or let me know if there's any chage you want in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants