Change pipes to force connections to covers #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When placing a filter or transfer cover on a pipe, the pipe is visually forced to connect to the cover. This PR makes it so that applying a cover also forces a logical connection from the pipe to the side that the cover is one.
In order to prevent mishaps, when a cover is removed from a pipe it will now also forcibly disconnect the pipe.
Implementation Details
Only applies to covers that return
falseincanPipePassThrough.Outcome
Fixes #2660
Additional Information
Storage covers have been changed to only be placeable on machines.
Fluid Filters use the native
getFluidHandlerCapof its cover container rather than querying the caps system