Hacky fix for EMI recipe tree rendering #2736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix GregTechCEu#2735 by doing a partial revert of the changes to GTRecipeEMICategory in 039659f I suspect this works due to some implementation detail of EmiTexture/EmiDrawContext setting z to 0 or something? I couldn't figure out the full details myself; please reject this if you know the "proper" way to fix this.
|
I'm legitimately confused how the category icon messes this up. I'm gonna do some testing and get back to you on this, if that's ok. |
|
Yeah, I wouldn't believe it either if git bisect didn't lead me here. I'd much prefer a proper fix instead of merging this PR; I mostly just raised it to demonstrate exactly where the issue is happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix EMI recipe tree rendering by doing a partial revert of the changes to GTRecipeEMICategory in 039659f
Implementation Details
I suspect this works due to some implementation detail of EmiTexture/EmiDrawContext setting z to 0 or something? I couldn't figure out the full details myself; please reject this if you know the "proper" way to fix this.
Outcome
Fixes #2735