Recompress png assets with oxipng #2743
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run oxiping against the assets folder to reduce texture filesize
Implementation Details
Oxipng supports a load of complex options for discarding extra data; to be safe, I didn't user any of these and just ran it with default settings (
oxipng --recursive src/main/resources
).Outcome
Jar shrinks a tiny bit (14.3MB -> 13.4MB?)
Additional Information
Some textures look a little different in the diff view (e.g.
resources/assets/gtceu/textures/block/multiblock/large_turbine/blade_active/1.png
, but in-game these look fine - I assume probably related to changing background color of transparent pixels or something?We could consider setting up gradle/github actions to run this optimization automatically, but given the small improvement I think just doing a one-off run is enough.